Changes between Version 2 and Version 3 of Ticket #55635, comment 4
- Timestamp:
- 04/28/2022 02:07:49 AM (4 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #55635, comment 4
v2 v3 14 14 It's worth noting, that just because PHP parses it one way, it's not necessarily strictly required that `wp_convert_hr_to_bytes()` should handle those extreme edge-cases.. but there's some obvious improvements that can be made here. 15 15 16 Also, to save some time, here's the PHP intval underlying C code I've used for reference: https://github.com/php/php-src/blob/b5db594fd277464104fce814d22f0b2207d6502d/ext/standard/type.c#L142-L199 which is ultimately passed through the C function [https://www. tutorialspoint.com/c_standard_library/c_function_strtol.htm `strtol()`].16 Also, to save some time, here's the PHP intval underlying C code I've used for reference: https://github.com/php/php-src/blob/b5db594fd277464104fce814d22f0b2207d6502d/ext/standard/type.c#L142-L199 which is ultimately passed through the C function [https://www.cplusplus.com/reference/cstdlib/strtol/ strtol()].