Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #55635, comment 6


Ignore:
Timestamp:
04/28/2022 03:47:53 AM (4 years ago)
Author:
dmsnell
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #55635, comment 6

    initial v1  
    1 @dd32 another quick thing: I considered moving this function into a new file such as `wp-includes/php-compat.php` but ultimately chose not to because that would involve adding a new file and then needing to `require` it inside `load.php`. That's still an option and possibly a way to isolate it's more nuanced behavior from the more general WordPress code int he rest of the file. It could also add a nice way to separate some of the more cluttered parts of this function into separate helpers. If you think it's worth doing that I'd be happy to do so, but so far figured folks would prefer leaving this as-is in place since it doesn't require that level of separation yet.
     1@dd32 another quick thing: I considered moving this function into a new file such as `wp-includes/php-compat.php` but ultimately chose not to because that would involve adding a new file and then needing to `require` it inside `load.php`. That's still an option and possibly a way to isolate its more nuanced behavior from the more general WordPress code in the rest of the file. It could also add a nice way to separate some of the more cluttered parts of this function into separate helpers. If you think it's worth doing that I'd be happy to do so, but so far figured folks would prefer leaving this as-is in place since it doesn't require that level of separation yet.