Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55661 closed defect (bug) (fixed)

Typo in string about dropdown theme locations

Reported by: nekojonez's profile NekoJonez Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.1 Priority: normal
Severity: trivial Version: 3.6
Component: Menus Keywords: has-patch
Focuses: ui, administration Cc:

Description

https://build.trac.wordpress.org/browser/trunk/wp-admin/nav-menus.php?marks=655#L655

Shouldn't "Drop down" here be one word instead of two with a space?

Attachments (1)

55661.diff (3.0 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in Slack in #polyglots by nekojonez. View the logs.


2 years ago

#2 @NekoJonez
2 years ago

  • Summary changed from Minor typo in string for WP 6.0 to Typo in string about dropdown theme locations

This ticket was mentioned in PR #2665 on WordPress/wordpress-develop by NekoJonez.


2 years ago
#3

  • Keywords has-patch added

Durin translation of WP v6.0 , I found a typo in the word dropdown. And I wanted to fix it!

Trac ticket: (https://core.trac.wordpress.org/ticket/55661)

#4 follow-up: @mukesh27
2 years ago

Hi there!

Thanks for the ticket and PR.

Can you please globally search on WP files and replace this word?

#5 in reply to: ↑ 4 @NekoJonez
2 years ago

Replying to mukesh27:

Hi there!

Thanks for the ticket and PR.

Can you please globally search on WP files and replace this word?

In terms of visible strings to the user... It was the only one. It's possible that in code commentary it's still there. But I think I got them all in that PR.

@SergeyBiryukov
2 years ago

#6 @mukesh27
2 years ago

Thanks for patch @SergeyBiryukov

#7 @SergeyBiryukov
2 years ago

  • Component changed from General to Menus
  • Milestone changed from Awaiting Review to 6.1

Thanks for the ticket!

Filters the number of locations listed per menu in the drop-down select.

I think drop-down is correct here, it's a compound adjective and does need the hyphen. When used as a noun, dropdown is also acceptable. However, drop down indeed appears to be not quite correct.

Reference: Dropdown, Drop down, or Drop-down? [grammarhow.com]

Looking at the core files:

  • dropdown (as a standalone word): 145 matches in 41 files
  • drop-down: 47 matches in 17 files
  • drop down: 4 matches in 2 files

There's one more drop down instance in the same file that should also be corrected, and two more in another file.

Moving this to 6.1, as we're in string freeze for 6.0, and these strings are not new and have been around since WordPress 3.6, see [23844] / #23608. For the wp_dropdown_page DocBlock, see [27676] / #25621.

Last edited 2 years ago by SergeyBiryukov (previous) (diff)

#8 @SergeyBiryukov
2 years ago

  • Version set to 3.6

This ticket was mentioned in Slack in #core by nekojonez. View the logs.


2 years ago

#10 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 53391:

Menus: Replace "drop down" (noun) with "dropdown" in a few strings.

This makes the spelling more consistent with other instances of the word in core.

Follow-up to [23844], [27676].

Props NekoJonez, mukesh27, SergeyBiryukov.
Fixes #55661.

Note: See TracTickets for help on using tickets.