Translatable strings ending with space, otherwise identical to other strings

[knutsp]

Version 6.0 (not listed yet)

wp-includes/js/dist/block-library.js:9610 "Response to "
wp-includes/js/dist/block-library.js:9611 "responses to "
wp-includes/js/dist/block-library.js:9612 "Responses to "

Can these be normalized by moving the trailing space outside translation function?

[swissspidy]

Better yet, these strings should use proper %s placeholders and translator comments.

String concatenation and strings with trailing spaces are definitely discouraged.

The culprit code is here:

​https://github.com/WordPress/gutenberg/blob/fa456ec87bb6504f0c116ef4e759e74b8873a4ff/packages/block-library/src/comments-title/edit.js#L139-L153

[Bernhard Reiter]

Thanks! Gutenberg PR to fix the issue now available: ​https://github.com/WordPress/gutenberg/pull/40817

[psmits1567]

This is not only related to blocks!
It is a general problem in projects as well. Original strings should not start or end with a blanc. They are not visible in GlotPress at least the ending one not. So translators omit them, thus causing the translation not shown properly

[johnbillion]

@psmits1567 Are there other instances you've found of trailing spaces in strings for translation in WordPress core? Could you point us to them if so? Thanks.

[psmits1567]

@johnbillion not in core, but in themes, plugins
For those I have currently no examples on hand.

[Bernhard Reiter]

One more PR that fixes a similar i18n issue with the Post Comments block: ​https://github.com/WordPress/gutenberg/pull/40849

[hellofromTonya]

Replying to Bernhard Reiter:

One more PR that fixes a similar i18n issue with the Post Comments block: ​https://github.com/WordPress/gutenberg/pull/40849

Replying to swissspidy:

The culprit code is here:

​https://github.com/WordPress/gutenberg/blob/fa456ec87bb6504f0c116ef4e759e74b8873a4ff/packages/block-library/src/comments-title/edit.js#L139-L153

The Post Comment block's post title translations fix was committed in [53377] and [53378] as part of #55567 and was backported to 6.0 branch [53381] for 6.0 RC2.

[peterwilsoncc]

This issue was fixed with a package update on #55567 in the lead up to WP 6.0 RC2.