Search widget doesn't use searchform.php

[Pixelstyle]

The search widget doesn't use rthe standard searchform.php

I've found two tickets about the search widget, but none of them suggests the most logical solution to the probnlem, namely to make the widget use searchform.php.

It might be that this is a conscious choice because not all themes have a searchform.php. But then it would be logical to make it an option on the search widget option button (use searchform.php: tickbox).

[ionfish]

+1

The default theme has a searchform.php which the widget should default to if the current theme has no searchform.php file.

[lloydbudd]

No patch, milestone defaults to current+1.

[ionfish]

Works fine for me, both with a theme's searchform.php and with the default one when the theme has no searchform.php file.

[ionfish]

Same as above but diffed from WP root for convenience.

[ionfish]

Attached an improved patch which doesn't reveal the origin of the search form publicly and has more WordPressy syntax.

[Otto42]

+1 to this, however it would be nice if the default search box had an id of "searchsubmit" on the submit button.

<input type="submit" id="searchsubmit" value="<?php echo attribute_escape(__('Search')); ?>" />

This is in line with the existing searchform.php file in the default theme, and makes styling of the submit button possible.

[ionfish]

Sorry Otto, I'm not sure I follow. The patch makes the search widget use either the theme's searchform.php or the default theme's searchform.php if the theme doesn't have one. If the default theme's searchform.php has an id of "searchsubmit" then search widgets will get that simply in virtue of them using the same source file.

[ionfish]

Any more comments or a chance of getting this in for 2.5?

[ionfish]

Bumping to 2.6.

[Otto42]

Any chance of this getting into 2.5.2 already?

[JohnLamansky]

+1 for getting this into 2.5.2

[ryan]

It's not uncommon for people to delete the default theme. If the current theme doesn't supply a search form, let's just emit one and forgo looking at the default theme.

[Otto42]

Replying to ryan:

It's not uncommon for people to delete the default theme. If the current theme doesn't supply a search form, let's just emit one and forgo looking at the default theme.

There's several places in the core code where it looks at the default theme for stuff like this. I refer you to get_header, get_footer, get_sidebar...

We often say on the support forums that deleting the default theme is not recommended because of that fact.

And quite frankly, I think that it *is* uncommon for people to delete the default theme.

So I'm going to go with leaving it to look for one in the default theme directory, because of all those reasons.

[ryan]

With the advent of WP_CONTENT_DIR, it will become more common. I don't have the default theme in my WP_CONTENT_DIR.

get_header() and friends have the advantage that a theme almost never calls them if it doesn't also supply the corresponding files. The same cannot be said for a widget.

[ionfish]

Updated patch reflecting Ryan's point attached.

[ryan]

(In [8250]) Use searchform.php for search widget, if available. Props ionfish. fixes #5567