block-templates theme support not present in /themes REST API endpoint

[grantmkin]

The block-templates theme support is not present in the theme_supports REST API data for the active theme.

• Activate a theme that supports block templates, like Twenty Twenty Two
• Access /wp-json/wp/v2/themes?status=active
• See that block-templates is not including in the theme_supports data

Registers the block-templates theme support. This ensures it is included in the theme_supports data of the active theme in the /wp-json/wp/v2/themes?status=active endpoint.

Trac ticket: https://core.trac.wordpress.org/ticket/55681

[hellofromTonya]

Moving into the 5.9.4 for visibility.

Thanks for the PR @creativecoder,

It looks like we need to update the WP_Test_REST_Themes_Controller::test_get_item_schema test to account for this new theme feature.

Thanks for the pointer @TimothyBJacobs !

I've modified the test... everything looks ✅ now.

[audrasjb]

Moving this ticket to next major release since it wasn't addressed during this cycle. Anyone is welcome to move it back to 6.0.x minor releases cycle if a patch is ready to ship.

[SergeyBiryukov]

The patch seems straightforward enough, I think this can be fixed in 6.0.1.

@TimothyBJacobs @creativecoder - Is there anything else holding this PR back, or is this ready to go?

Nope, it's on my list to commit @Addison-Stavlo.

@creativecoder - just for my understanding, can you explain why the block-templates code snippet was place inside the themes.php file and specifically within the create_initial_theme_features function?

@creativecoder - just for my understanding, can you explain why the block-templates code snippet was place inside the themes.php file and specifically within the create_initial_theme_features function?

@agrullon95 Sorry for the delayed reply here. create_initial_theme_features looks to be the place where all theme supports that are recognized by WP Core are registered. While debugging https://core.trac.wordpress.org/ticket/55681, I found that registering a theme support is required to have it show in the API response for the active theme.

The block-templates theme support ​is used by the editor component (a.k.a. Gutenberg) and it looks like registering it was overlooked when that theme support was introduced.

[SergeyBiryukov]

Hi @TimothyBlynJacobs, I see you're listed as the owner. Do you think this PR has anything else to consider, or is it good to go? Would be great to include it in 6.0.1 RC1 tomorrow :)

[TimothyBlynJacobs]

Nope, I think it's good to go! Feel free to take it.

[SergeyBiryukov]

In 53659:

Themes: Register the block-templates theme feature.

This ensures the feature is included in the theme_supports REST API data for the active theme.

Follow-up to [48171].

Props grantmkin, TimothyBlynJacobs, addiestavlo.
Fixes #55681.

[SergeyBiryukov]

In 53661:

Themes: Register the block-templates theme feature.

This ensures the feature is included in the theme_supports REST API data for the active theme.

Follow-up to [48171].

Props grantmkin, TimothyBlynJacobs, addiestavlo.
Merges [53659] to the 6.0 branch.
Fixes #55681.

Thanks for the PR! Merged in r53659, backported to the 6.0 branch in r53661.