WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#55683 closed defect (bug) (fixed)

Unused variables in WP_Site_Health::get_test_plugin_version

Reported by: davidbinda's profile david.binda Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.1 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: commit has-patch
Focuses: Cc:

Description

I have noticed, that the $plugins_have_updates and $plugin_version variables in WP_Site_Health::get_test_plugin_version method are not being used, and have actually never been used since their introduction in r44986

IMHO, those should be removed in order to make the code more readable.

Attachments (1)

55683.diff​ (718 bytes) - added by david.binda 3 years ago.

Download all attachments as: .zip

Change History (3)

@david.binda
3 years ago

#1 @mukesh27
3 years ago

  • Keywords commit has-patch added
  • Milestone changed from Awaiting Review to 6.1

Agree with @davidbinda

Patch 55683.diff​ look good to me.

Let's move this ticket to 6.1 consideration and add the commit keyword.

#2 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 53355:

Site Health: Remove unused variables in WP_Site_Health::get_test_plugin_version().

Follow-up to [44986].

Props david.binda, mukesh27.
Fixes #55683.

Note: See TracTickets for help on using tickets.