Make WordPress Core

#55693 closed enhancement (wontfix)

TinyMCE WordPress plugin contains unnecessary code

Reported by: mattyrob's profile MattyRob Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9.7
Component: TinyMCE Keywords: reporter-feedback
Focuses: Cc:

Description (last modified by sabernhardt)

I hope I am correct here, I have been tracking through a long trail of changes, but...

Changeset r43336 added some line breaks corrects implemented in the case that hasWpautop evaluated to false.

This seems to have been linked to the gutenberg_disable_editor_settings_wpautop function in the Gutenberg plugin at version 2.7, but is seems this same function was removed in Gutenberg 5.2.0.

A shim for this was added and then removed in Gutenberg itself, the removal once r43336 was merged to WordPress.

So, my question / issue is, is it time to remove r43336 from the core WordPress code?

References to some useful links that support the above are listed below.

Change History (4)

#1 @sabernhardt
19 months ago

  • Component changed from Editor to TinyMCE
  • Description modified (diff)
  • Version trunk deleted

#2 @SergeyBiryukov
19 months ago

  • Milestone changed from Awaiting Review to 6.1

#3 @desrosj
15 months ago

  • Keywords reporter-feedback added
  • Version set to 4.9.7

Pinging @azaozz as the committer for [43336].

@MattyRob are you experiencing any undesired effects from [43336]? Or are you just trying to confirm that the change is no longer necessary?

#4 @azaozz
15 months ago

  • Milestone 6.1 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The code from [43336] only runs before the HTML is loaded in TinyMCE, both on page load and when switching Text->Visual mode. It prepares the HTML for loading/parsing.

Unfortunately there is a bug in TinyMCE that would make paragraphs out of HTML comments (the same bug was fixed in autop earlier). That commit fixes it "just in time" and doesn't (shouldn't) affect anything else.

Closing as wontfix as it prevents a bug from upstream. Please feel free to reopen if this is causing any problems.

Note: See TracTickets for help on using tickets.