WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#55701 closed defect (bug) (fixed)

ms-load mentions MySQL

Reported by: tobifjellner's profile tobifjellner Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Database Keywords: good-first-bug has-patch
Focuses: multisite Cc:

Description

At lest one error message in ms-load.php mentions MySQL.

<strong>Database tables are missing.</strong> This means that MySQL is not running, WordPress was not installed properly, or someone deleted %s. You really should look at your database now.

This should, when possible, be changed to a generic reference about the database server.
Ref: ​https://build.trac.wordpress.org/browser/trunk/wp-includes/ms-load.php?marks=480#L480

Change History (10)

#1 @SergeyBiryukov
3 years ago

  • Focuses multisite added
  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 6.1

#3 @audrasjb
3 years ago

  • Version trunk deleted

#4 @hansjovisyoast
3 years ago

I'm claiming this one for the contributor day today :).

This ticket was mentioned in ​PR #2712 on ​WordPress/wordpress-develop by ​tj692.
3 years ago #5

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/55701

This commit replaces mentions to MySQL with generic mentions to "your database".

#6 follow-up: @hansjovisyoast
3 years ago

A first time contributor that I mentored today made the patch: ​https://github.com/tj692 🎉.

#7 in reply to: ↑ 6 @SergeyBiryukov
3 years ago

Replying to hansjovisyoast:

A first time contributor that I mentored today made the patch: ​https://github.com/tj692 🎉.

Hi @hansjovisyoast, that's great, thank you! Could they create a WordPress.org account so that the "props" could be given correctly in the commit message?

#8 @tj692
3 years ago

Hi, I have made an account. :)

#9 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 53394:

Database: Use generic references to a database server in ms_not_installed().

This replaces the references to “MySQL” with “your host’s database server” on the “Error establishing a database connection” page when Multisite could not be loaded. The generic “database server” term can refer to MySQL or MariaDB. Additionally, this brings some consistency with a similar error message in wpdb::db_connect().

Follow-up to [52367], [52423].

Props tj692, hansjovisyoast, tobifjellner.
Fixes #55701.

Note: See TracTickets for help on using tickets.