Make WordPress Core

#55708 closed enhancement (fixed)

Backport some Comment blocks test changes

Reported by: bernhard-reiter's profile Bernhard Reiter Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.0 Priority: normal
Severity: trivial Version:
Component: Editor Keywords: has-patch has-unit-tests commit
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Follow-up to #55643.

Comments block unit tests have now been backported, except for some very minor differences.

I'll file a PR to carry those differences over to wordpress-develop.
(Furthermore, I've already filed a PR to remove the tests from Gutenberg, following best practices.)

Change History (8)

This ticket was mentioned in PR #2695 on WordPress/wordpress-develop by ockham.


22 months ago
#1

  • Keywords has-patch has-unit-tests added

Comments blocks unit tests have been backported, from Gutenberg, except for some very minor differences.

This PR carries over those remaining changes, allowing us to remove the unit tests from GB (https://github.com/WordPress/gutenberg/pull/40965).

Trac ticket: https://core.trac.wordpress.org/ticket/55708

#2 @SergeyBiryukov
22 months ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 6.0

#3 @hellofromTonya
22 months ago

  • Keywords commit added
  • Owner set to hellofromTonya
  • Status changed from new to reviewing

The test changes LGTM! Well done. Self-assigning for commit.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


22 months ago

#5 @hellofromTonya
22 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53388:

Editor: Use stricter assertions in comment template tests.

Backport of the remaining Comment Template block tests from Gutenberg:

  • assertEquals() replaced with assertSameSetsWithIndex().
  • assertion's argument order changed to ensure expected and then actual.

Follow-up to [53353], [53298], [53172], [53138].

Props bernhard-reiter.
Fixes #55708.

#7 @hellofromTonya
22 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport to the 6.0-branch. Please note, commits to the test suite do not require double sign-off. Prepping backport commit now.

#8 @hellofromTonya
22 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 53389:

Editor: Use stricter assertions in comment template tests.

Backport of the remaining Comment Template block tests from Gutenberg:

  • assertEquals() replaced with assertSameSetsWithIndex().
  • assertion's argument order changed to ensure expected and then actual.

Follow-up to [53353], [53298], [53172], [53138].

Props bernhard-reiter.
Merges [53388] to the 6.0 branch.
Fixes #55708.

Note: See TracTickets for help on using tickets.