Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55709 closed defect (bug) (fixed)

untranslated $plugin_name parameter in wp_add_privacy_policy_content() call of twenty twenty-one theme

Reported by: nlpro's profile nlpro Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch
Focuses: privacy Cc:

Description

In wp-content\themes\twentytwentyone\classes\class-twenty-twenty-one-dark-mode.php:

<?php
wp_add_privacy_policy_content( 'Twenty Twenty-One', wp_kses_post( wpautop( $content, false ) ) );

should be:

<?php
wp_add_privacy_policy_content( __( 'Twenty Twenty-One', 'twentytwentyone' ), wp_kses_post( wpautop( $content, false ) ) );

Attachments (2)

screencapture-localhost-8888-552-wordpress-16-wp-admin-options-privacy-php-2022-05-11-10_08_56.png (450.3 KB) - added by audrasjb 2 years ago.
55709.diff (1.2 KB) - added by bhrugesh12 2 years ago.

Download all attachments as: .zip

Change History (7)

#1 @audrasjb
2 years ago

  • Keywords needs-patch added
  • Version changed from 5.9.3 to 5.9

introduced in WP 5.9 with TT2 bundled theme

Below I added a screenshot to show where the related content appears.

This looks like a relevant proposal to me 👍

#2 @bhrugesh12
2 years ago

  • Keywords has-patch added; needs-patch removed

Patch Added. Please check the attachment.

@bhrugesh12
2 years ago

#3 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 6.1
  • Owner set to audrasjb
  • Status changed from new to accepted

Looks good to me, thanks 👍

#4 @costdev
2 years ago

  • Component changed from Privacy to Bundled Theme
  • Version changed from 5.9 to 5.6

Introduced in 5.6 with changeset [49574].

#5 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in https://core.trac.wordpress.org/changeset/53390

Looks like Trac didn't catch up this commit for some reason, but it's committed, see https://github.com/WordPress/wordpress-develop/commit/4083456e421dca25d2e463edd2e4f4cb2757e9ed.

Version 0, edited 2 years ago by audrasjb (next)
Note: See TracTickets for help on using tickets.