Opened 4 years ago
Closed 2 years ago
#55713 closed defect (bug) (reported-upstream)
Styles welcome guide's button styling is not consistent
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | Editor | Keywords: | |
| Focuses: | ui, css | Cc: |
Description
I couldn't understand the logic behind having different styling for Previous and Get Started button than Next button, I believe buttons should have the same styling,
The next button has color 1386bf and font is bold, added a patch to make all buttons consistent
Attachments (2)
Change History (9)
#1
@
4 years ago
This ticket doesn't have the patch, it seems it needs to be fixed in components package https://github.com/WordPress/gutenberg/blob/7c35f5fef8e273153ab5e0d58999d8a1bb4df469/packages/components/src/guide/style.scss
Added a PR https://github.com/WordPress/gutenberg/pull/41022
#2
@
4 years ago
Hello @juhise
As per my understanding adding this line of code can solve this issue.
.components-button.components-guide__back-button {
color: #1386bf;
font-weight: 700;
}
.components-button.components-guide__finish-button {
color: #1386bf;
font-weight: 700;
}
.components-button.components-guide__finish-button:hover{
text-decoration:underline;
}
I am trying to add patch but did not able to find out path that's why i am sharing my code here.
Hope that will be helpful.
#3
@
4 years ago
Hey @nidhidhandhukiya
Yeah you are right, thanks for taking the time to share.
It's coming from an external package so needs to be fixed in that package only, I believe.
I have added a PR for that https://github.com/WordPress/gutenberg/pull/41022
#4
@
4 years ago
- Component changed from General to Editor
- Keywords reporter-feedback added
Hi @juhise, thanks for opening this ticket!
As this would require a change in the Gutenberg project, this should be created as a new issue on the Gutenberg repository if it's not already mentioned in the list of existing issues.
When you find/create an issue for this, please drop the link into a comment here so folks can find it and then I'll close this ticket as reported-upstream.
Thanks!
#5
@
4 years ago
Hi
I have created an issue on the Gutenberg repo https://github.com/WordPress/gutenberg/issues/41226
Thanks!
#6
@
2 years ago
This problem cannot be reproduced with the latest Gutenberg, so I think we can close this ticket. For more information, see this comment on Gutenberg PR: https://github.com/WordPress/gutenberg/pull/41022#issuecomment-1862716432
next button with #1386bf color and font bold