Make WordPress Core

Opened 2 years ago

Closed 7 months ago

#55713 closed defect (bug) (reported-upstream)

Styles welcome guide's button styling is not consistent

Reported by: juhise's profile juhise Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: ui, css Cc:

Description

I couldn't understand the logic behind having different styling for Previous and Get Started button than Next button, I believe buttons should have the same styling,

The next button has color 1386bf and font is bold, added a patch to make all buttons consistent

Attachments (2)

next-button.png (52.7 KB) - added by juhise 2 years ago.
next button with #1386bf color and font bold
previous-getstarted-button.png (53.2 KB) - added by juhise 2 years ago.
Previous & Get Started button styling is different

Download all attachments as: .zip

Change History (9)

@juhise
2 years ago

next button with #1386bf color and font bold

@juhise
2 years ago

Previous & Get Started button styling is different

#2 @nidhidhandhukiya
2 years ago

Hello @juhise
As per my understanding adding this line of code can solve this issue.

.components-button.components-guide__back-button {
    color: #1386bf;
    font-weight: 700;
}

.components-button.components-guide__finish-button {
    color: #1386bf;
    font-weight: 700;
}
.components-button.components-guide__finish-button:hover{
    text-decoration:underline;
}

I am trying to add patch but did not able to find out path that's why i am sharing my code here.
Hope that will be helpful.

#3 @juhise
2 years ago

Hey @nidhidhandhukiya
Yeah you are right, thanks for taking the time to share.
It's coming from an external package so needs to be fixed in that package only, I believe.
I have added a PR for that https://github.com/WordPress/gutenberg/pull/41022

Last edited 2 years ago by juhise (previous) (diff)

#4 @costdev
2 years ago

  • Component changed from General to Editor
  • Keywords reporter-feedback added

Hi @juhise, thanks for opening this ticket!

As this would require a change in the Gutenberg project, this should be created as a new issue on the Gutenberg repository if it's not already mentioned in the list of existing issues.

When you find/create an issue for this, please drop the link into a comment here so folks can find it and then I'll close this ticket as reported-upstream.

Thanks!

#5 @juhise
2 years ago

Hi
I have created an issue on the Gutenberg repo https://github.com/WordPress/gutenberg/issues/41226

Thanks!

#6 @wildworks
7 months ago

This problem cannot be reproduced with the latest Gutenberg, so I think we can close this ticket. For more information, see this comment on Gutenberg PR: https://github.com/WordPress/gutenberg/pull/41022#issuecomment-1862716432

#7 @sabernhardt
7 months ago

  • Keywords reporter-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

reported upstream in GB41226

Note: See TracTickets for help on using tickets.