Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#55724 closed defect (bug) (fixed)

Twenty Twenty-One: Comment missing at the end of HTML tag

Reported by: haritpanchal's profile haritpanchal Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

In the Twentytwentyone theme, I have come to find that the HTML tag comment is missing. As per WordPress coding standards, a comment should be there to show which HTML tag is ended.

Attachments (1)

55724.patch (503 bytes) - added by haritpanchal 2 years ago.
Patch Added

Download all attachments as: .zip

Change History (6)

@haritpanchal
2 years ago

Patch Added

#1 @haritpanchal
2 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
2 years ago

  • Component changed from Themes to Bundled Theme
  • Focuses accessibility docs removed
  • Milestone changed from Awaiting Review to 6.1
  • Summary changed from Comment missing At end of HTML tag to Twenty Twenty-One: Comment missing at the end of HTML tag

#3 @audrasjb
2 years ago

  • Keywords commit added
  • Type changed from enhancement to defect (bug)
  • Version 5.9.3 deleted

Welcome back to WWordPress Trac and thank you for this ticket,

The above patch looks good to me: it adds an HTML comment when we're not in a singular Post.

#4 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#5 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53399:

Twenty Twenty-One: Add a missing HTML comment to indicate the end of .post-thumbnail section.

Props haritpanchal.
Fixes #55724.

Note: See TracTickets for help on using tickets.