WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#55725 closed enhancement (fixed)

Twenty Twenty-One: Comment missing at the end of HTML tag in class file

Reported by: haritpanchal's profile haritpanchal Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version: 5.9.3
Component: Bundled Theme Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

In the Twentytwentyone theme class file, one HTML tag comment is missing. As per WordPress coding standards, a comment should be there to show which HTML tag is ended.

Attachments (1)

55725.patch​ (846 bytes) - added by haritpanchal 2 years ago.
Patch Added

Download all attachments as: .zip

Change History (9)

@haritpanchal
2 years ago

Patch Added

#1 @haritpanchal
2 years ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
2 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Comment missing At end of HTML tag in Class file. to Twenty Twenty-One: Comment missing at the end of HTML tag in class file

#3 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.1

#4 @audrasjb
2 years ago

  • Keywords 2nd-opinion added

Hello and thank you for opening this ticket and for the related patch,

I'm only wondering if it's worth adding this kind of HTML comments in WP-Admin related HTML code. Indeed, this code is used to generate some customizer controls, so I'm not sure it's worth using HTML closure comment in that case.

#5 @haritpanchal
2 years ago

I guess you are right but I went through some older themes' class files (twentynineteen) and they have such HTML comments. My main concern was coding standards so I created this ticket.

#6 @haritpanchal
2 years ago

  • Keywords changes-requested added

#7 @audrasjb
2 years ago

  • Keywords commit added; 2nd-opinion changes-requested removed
  • Owner set to audrasjb
  • Status changed from new to accepted

OK then let's ship this small change for consistency.

#8 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 54221:

Twenty Twenty-One: Add a missing HTML comment for Customizer notice control.

This brings consistency with other bundled themes, like Twenty Nineteen.

Props haritpanchal.
Fixes #55725.

Note: See TracTickets for help on using tickets.