#55750 closed defect (bug) (fixed)
About Page: Header images from previous release are cached
Reported by: | ryelle | Owned by: | ryelle |
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Help/About | Keywords: | has-patch fixed-major dev-reviewed |
Focuses: | Cc: |
Description
When updating to 6.0 RC3 & viewing the About page, I still saw the old 5.9 image in the header. The image uses the same file name, so it must be locally cached.
This is similar to the issue raised in #55689, but the change on the welcome panel made that one invalid - the solution can be the same though, append the version to the background image URLs.
Attachments (1)
Change History (8)
This ticket was mentioned in PR #2724 on WordPress/wordpress-develop by ryelle.
2 years ago
#1
- Keywords has-patch added
peterwilsoncc commented on PR #2724:
2 years ago
#3
#4
@
2 years ago
- Keywords dev-feedback fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for merging to the 6.0 branch pending another committers review.
#5
@
2 years ago
- Keywords dev-reviewed added; dev-feedback removed
Alright the change looks good to me, this can be backported to branch 6.0.
#7
@
2 years ago
In the future, would it make sense to create a build task for this, perhaps as part of grunt prerelease
, so that we don't forget to bump the version here?
This appends the version to the header image URLs. It uses the major version only, since these images will not change in minor releases. This uses the same approach that was proposed in https://github.com/WordPress/wordpress-develop/pull/2686.
Trac ticket: https://core.trac.wordpress.org/ticket/55750