Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55750 closed defect (bug) (fixed)

About Page: Header images from previous release are cached

Reported by: ryelle's profile ryelle Owned by: ryelle's profile ryelle
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch fixed-major dev-reviewed
Focuses: Cc:

Description

When updating to 6.0 RC3 & viewing the About page, I still saw the old 5.9 image in the header. The image uses the same file name, so it must be locally cached.

This is similar to the issue raised in #55689, but the change on the welcome panel made that one invalid - the solution can be the same though, append the version to the background image URLs.

Attachments (1)

about-header.png (211.1 KB) - added by ryelle 2 years ago.

Download all attachments as: .zip

Change History (8)

@ryelle
2 years ago

This ticket was mentioned in PR #2724 on WordPress/wordpress-develop by ryelle.


2 years ago
#1

  • Keywords has-patch added

This appends the version to the header image URLs. It uses the major version only, since these images will not change in minor releases. This uses the same approach that was proposed in https://github.com/WordPress/wordpress-develop/pull/2686.

Trac ticket: https://core.trac.wordpress.org/ticket/55750

#2 @peterwilsoncc
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53409:

Help/About: Ensure about page shows current header.

Add a query string parameter to the about page header images to ensure the cache is broken in browsers and CDNs.

Props ryelle.
Fixes #55750.

#4 @peterwilsoncc
2 years ago

  • Keywords dev-feedback fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 6.0 branch pending another committers review.

#5 @audrasjb
2 years ago

  • Keywords dev-reviewed added; dev-feedback removed

Alright the change looks good to me, this can be backported to branch 6.0.

#6 @ryelle
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 53412:

Help/About: Ensure about page shows current header.

Add a query string parameter to the about page header images to ensure the cache is broken in browsers and CDNs.

Props ryelle.
Merges [53409] to the 6.0 branch.
Fixes #55750.

#7 @SergeyBiryukov
2 years ago

In the future, would it make sense to create a build task for this, perhaps as part of grunt prerelease, or maybe a unit test, so that we don't forget to bump the version here?

Last edited 2 years ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.