Opened 4 years ago
Closed 4 years ago
#55752 closed defect (bug) (fixed)
site-editor.php query params disappear
| Reported by: | grantmkin | Owned by: | peterwilsoncc |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.0 |
| Component: | Editor | Version: | 6.0 |
| Severity: | normal | Keywords: | has-patch fixed-major commit dev-reviewed |
| Cc: | Focuses: |
Description (last modified by )
The Site editor supports adding query params, like styles=open to open the the Global Styles panel when the editor is loaded. These params are disappearing.
It looks like the changes in [53093] might be the cause. cc @gziolo
To reproduce
- Visit
/wp-admin/site-editor.php, close the sidebar to set its state to closed - Visit
/wp-admin/site-editor.php?styles=open
Expected
- The Global Styles panel is open
Actual
- The Global styles panel does not open
Change History (11)
This ticket was mentioned in Slack in #core-editor by grantmkin. View the logs.
4 years ago
This ticket was mentioned in PR #2727 on WordPress/wordpress-develop by Mamaduka.
4 years ago
#4
- Keywords has-patch added
PR fixes the issue when query parameters are removed on Site Editor homepage redirection.
Trac ticket: https://core.trac.wordpress.org/ticket/55752
peterwilsoncc commented on PR #2727:
4 years ago
#6
#7
@
4 years ago
- Keywords dev-feedback fixed-major added
- Resolution fixed
- Status closed → reopened
Reopening for merging in to the 6.0 branch upon a second committer's approval.
There was a report in the Gutenberg repo of problems on mobile due to responsive logic, this commit does not fix that issue. It only fixes the issue on desktop.
#8
@
4 years ago
- Keywords commit added
[53413] looks good for backporting to 6.0.
There was a report in the Gutenberg repo of problems on mobile due to responsive logic, this commit does not fix that issue.
Yes, that's a bigger problem because editing the template usually requires definitely more CPU than editing a page/post content.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Hi there, welcome back to WordPress Trac! Thanks for the ticket.
Moving to the milestone for visibility.