Make WordPress Core

Opened 19 months ago

Closed 15 months ago

Last modified 15 months ago

#55758 closed enhancement (fixed)

Remove self-references ("we") in text in core, take 2

Reported by: kebbet's profile kebbet Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: has-patch has-copy-review
Focuses: ui-copy Cc:

Description

This is a follow up ticket to #46057 which is closed and marked as fixed.

Some more instances was found. There are more of them in privacy-related strings, but I left them out from this list.

If you reach out to us, we'll also ensure you'll never have this problem again.
	wp-admin/includes/class-wp-automatic-updater.php:832

When you've been able to update using the "Update now" button on Dashboard > Updates, we'll clear this error for future update attempts.
	wp-admin/includes/class-wp-site-health-auto-updates.php:169


We'll try again with the next release.
	wp-admin/includes/class-wp-site-health-auto-updates.php:186


The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.
    wp-admin/includes/update-core.php:1169
    wp-admin/includes/update-core.php:1205


We couldn’t locate %s. Please try another nearby city. For example: Kansas City; Springfield; Portland.
	wp-admin/js/dashboard.js:570

There doesn't seem to be a %s file. I need this before we can get started.
	wp-load.php:90

Attachments (2)

55758-php.diff (3.9 KB) - added by kebbet 17 months ago.
Changes to PHP-files.
55758-php-2.diff (3.9 KB) - added by kebbet 17 months ago.

Download all attachments as: .zip

Change History (18)

#1 @kebbet
17 months ago

  • Keywords needs-testing needs-copy-review has-patch added; needs-patch removed
  • Severity changed from minor to normal

All suggestions for PHP-files in a combined patch.

If you reach out to us, we'll also ensure you'll never have this problem again.
If you reach out to us, the WordPress developers will also ensure you'll never have this problem again.

When you've been able to update using the "Update now" button on Dashboard > Updates, we'll clear this error for future update attempts.
When you've been able to update using the \"Update now\" button on Dashboard > Updates, this error will be cleared for future update attempts.

We'll try again with the next release.
At the next release, a new attempt will be made.

The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.
The update cannot be installed because some files are not possible to copy. This is usually due to inconsistent file permissions.

There doesn't seem to be a %s file. I need this before we can get started.
There doesn't seem to be a %s file. It is needed before the installation can continue.

@kebbet
17 months ago

Changes to PHP-files.

#2 follow-up: @costdev
17 months ago

Thanks for reaching out for feedback @kebbet!

Here's some initial thoughts:

If you reach out to us, we'll also ensure you'll never have this problem again.

Reach out to WordPress Core developers to ensure you'll never have this problem again.

  • While this ticket is about removing "we", I think "us" is a similar issue.
  • By specifying "WordPress Core developers", this makes it more likely that users come to the right place, and don't just find "WordPress developers".


We'll try again with the next release.

Another attempt will be made with the next release.

  • This is just because it's closer to the original text.


The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.

The update cannot be installed because some files cannot be copied. This is usually due to inconsistent file permissions.
OR
The update was not installed because some files could not be copied. This is usually due to inconsistent file permissions.

  • "are not possible to copy" reads a little strange to me.
  • The Alternative option may be preferred to avoid using "cannot" twice.

Also pinging @marybaum for copy review. Tag, you're it!

#3 in reply to: ↑ 2 @kebbet
17 months ago

Thank you for your feedback @costdev!

Replying to costdev:

Thanks for reaching out for feedback .kebbet!

Here's some initial thoughts:

If you reach out to us, we'll also ensure you'll never have this problem again.

Reach out to WordPress Core developers to ensure you'll never have this problem again.

  • While this ticket is about removing "we", I think "us" is a similar issue.
  • By specifying "WordPress Core developers", this makes it more likely that users come to the right place, and don't just find "WordPress developers".

Nice suggestion, sounds better to me!


We'll try again with the next release.

Another attempt will be made with the next release.

  • This is just because it's closer to the original text.

Nice suggestion too, sounds better to me!

The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.

The update cannot be installed because some files cannot be copied. This is usually due to inconsistent file permissions.
OR
The update was not installed because some files could not be copied. This is usually due to inconsistent file permissions.

  • "are not possible to copy" reads a little strange to me.
  • The Alternative option may be preferred to avoid using "cannot" twice.

Not so sure about changeing from cannot (future) to was not (past), but agree double up of cannot is not preffered.

Maybe: The update cannot be installed because some files could not be copied. This is usually due to inconsistent file permissions.?

#4 @costdev
17 months ago

Not so sure about changeing from cannot (future) to was not (past), but agree double up of cannot is not preffered.

Excellent point. These appear to be pre-update checks that are failing.

Maybe: The update cannot be installed because some files could not be copied. This is usually due to inconsistent file permissions.?

These appear to be pre-update checks, so the attempt to copy the files has not yet taken place, it's just checked to see if they can be copied. therefore "could not" and my previous suggestion of "was not" don't seem appropriate here.


The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.

What about replacing "we" with "WordPress"?

The update cannot be installed because WordPress will be unable to copy some files. This is usually due to inconsistent file permissions.

Also, I wonder, should it be "is unable" rather than "will be unable"?
i.e. "The future cannot happen because of the present situation" instead of "The future cannot happen because the future cannot happen".

If so, maybe this is more accurate:
The update cannot be installed because WordPress is unable to copy some files. This is usually due to inconsistent file permissions.

#5 follow-up: @kebbet
17 months ago

Great improvement, but what about being a bit more precise:
The update cannot be installed because your WordPress site is unable to copy some files. This is usually due to inconsistent file permissions.

#6 in reply to: ↑ 5 @SergeyBiryukov
17 months ago

Replying to kebbet:

Great improvement, but what about being a bit more precise:
The update cannot be installed because your WordPress site is unable to copy some files. This is usually due to inconsistent file permissions.

Maybe just "your site" instead of "your WordPress site"?

The update cannot be installed because your site is unable to copy some files. This is usually due to inconsistent file permissions.

#7 @SergeyBiryukov
17 months ago

  • Milestone changed from Awaiting Review to 6.1

#8 @costdev
17 months ago

Nice improvements in accuracy and brevity here. Our latest revision in Sergey's comment is good to go IMO.

@kebbet
17 months ago

#9 @kebbet
17 months ago

  • Component changed from Administration to Text Changes
  • Keywords needs-copy-review removed

55758-php-2.diff implements the reviewed strings. Thank you @costdev & @SergeyBiryukov!
The patch now includes these changes:

There doesn't seem to be a %s file. I need this before we can get started.

There doesn't seem to be a %s file. It is needed before the installation can continue.

If you reach out to us, we'll also ensure you'll never have this problem again.

Reach out to WordPress Core developers to ensure you'll never have this problem again.

When you've been able to update using the \"Update now\" button on Dashboard > Updates, we'll clear this error for future update attempts.

When you've been able to update using the \"Update now\" button on Dashboard > Updates, this error will be cleared for future update attempts.

We'll try again with the next release.

Another attempt will be made with the next release.

The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.

The update cannot be installed because your site is unable to copy some files. This is usually due to inconsistent file permissions.

#10 @costdev
17 months ago

55758-php-2.diff LGTM 👍

As this ticket makes string changes only, is the needs-testing keyword accurate? Genuine question - I'm not sure what the answer is.

#11 @kebbet
17 months ago

  • Keywords has-copy-review added; needs-testing removed

Good question! Handbook here: https://make.wordpress.org/core/handbook/contribute/trac/keywords/
Updates keywords in accordance to how I interpret the situation.

#12 @kebbet
15 months ago

Any chance of getting this ticket into 6.1?

#13 @robinwpdeveloper
15 months ago

As per above discussions and suggestions, 55758-php-2.diff looks good to me.

Thanks everyone involved.
It would be great if we can ship this one in 6.1

Last edited 15 months ago by robinwpdeveloper (previous) (diff)

#14 @audrasjb
15 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#15 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54200:

Text Changes: Remove self-reference ("we") in WordPress Admin.

This changes some admin-area, user-facing text, to better match the guidelines and recommendations set forth in the make/core handbook, specifically:

the word “we” should be avoided (...) unless its made very clear which group is speaking

Follow-up to [51979], [53131], [53132], [53148], [53156].

Props kebbet, costdev, SergeyBiryukov.
Fixes #55758.
See #46057.

#16 @audrasjb
15 months ago

In 54201:

Coding Standards: Replace double quote with single quote in test_if_failed_update().

Follow-up to [54200].
See #55758.

Note: See TracTickets for help on using tickets.