Make WordPress Core

Opened 22 months ago

Closed 22 months ago

Last modified 22 months ago

#55775 closed defect (bug) (fixed)

About page: Add links to release notes and video.

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch commit dev-reviewed fixed-major
Focuses: Cc:

Description (last modified by mukesh27)

The WordPress 6.0 about page has two placeholder links that need to be filled.

  • 6.0 overview video link
  • 6.0 release notes

To avoid breaking string freeze, the latter should be added in the form

<?php
sprintf(
        /* translators: %s: WordPress version. */
        esc_url( __( 'https://wordpress.org/support/wordpress-version/version-%s/' ) ),
        '6-0'
)

Attachments (1)

55775.diff (1.5 KB) - added by ryelle 22 months ago.

Download all attachments as: .zip

Change History (17)

This ticket was mentioned in PR #2729 on WordPress/wordpress-develop by peterwilsoncc.


22 months ago
#1

  • Keywords has-patch added

https://core.trac.wordpress.org/ticket/55775

Not sure if this is premature, I've confirmed the string is in the admin project. It is, so this won't ruin hundreds of translators days.

This ticket was mentioned in Slack in #core by costdev. View the logs.


22 months ago

#3 @mukesh27
22 months ago

  • Description modified (diff)

As discussed on GIT let me update the ticket description.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


22 months ago

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


22 months ago

#6 @hellofromTonya
22 months ago

As discussed during today's prep for Dry Run, consensus to hold off committing PR 2729 until there's a video link. Then one commit can be made for resolve this ticket.

@ryelle
22 months ago

#7 @ryelle
22 months ago

55775.diff has the change from the PR (release notes link) and adds the video link on both the "Exploring WordPress 6.0" image & the "Watch a brief…" text.

#8 @peterwilsoncc
22 months ago

Thanks @ryelle, I've pushed that to my PR so I can make sure the tests still pass. I'll be surprised if they don't.

I'll commit to trunk today and ask a local committer to review for the 6.0 branch while we have sunlight. I think it's the end of your day.

#10 @peterwilsoncc
22 months ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 53442:

Help/About: Finalise links on about page.

Wrap up about page for 6.0 release.

Props ryelle, mukesh27, hellofromTonya, SergeyBiryukov, peterwilsoncc.
Fixes #55775.

#11 @peterwilsoncc
22 months ago

  • Keywords dev-feedback fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 6.0 branch.

Adding dev-feedback for another committer to review and replace with dev-reviewed.

I've created a PR for the backport against the 6.0 branch to ensure the tests are passing. They are, which is nice.

#12 @SergeyBiryukov
22 months ago

  • Keywords commit dev-reviewed added; dev-feedback removed

[53442] looks good to backport.

This ticket was mentioned in Slack in #core by peterwilsoncc. View the logs.


22 months ago

#14 @peterwilsoncc
22 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 53443:

Help/About: Finalise links on about page.

Wrap up about page for 6.0 release.

Props ryelle, mukesh27, hellofromTonya, SergeyBiryukov, peterwilsoncc.
Merges [53442] to the 6.0 branch.
Fixes #55775.

Note: See TracTickets for help on using tickets.