WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55779 closed enhancement (fixed)

autocomplete attribute needed for personal fields in the comment form

Reported by: juliemoynat's profile juliemoynat Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch add-to-field-guide
Focuses: accessibility Cc:

Description

Hi,

According to the WCAG ​Success Criterion 1.3.5: Identify Input Purpose, the purpose of each input field collecting information about the user should be programmatically determined.

So, in the comment form, we should have an autocomplete attribute for these fields:

  • Name: autocomplete="name"
  • Email: autocomplete="email"
  • Website: autocomplete="url"

​See the documentation to know more about the autocomplete values.

Change History (13)

#1 @costdev
2 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in ​PR #2739 on ​WordPress/wordpress-develop by ​thejaydip.
2 years ago #2

  • Keywords has-patch added

Added autocomplete attribute in the comment form - wp-includes/comment-template.php
Ref. (https://core.trac.wordpress.org/ticket/55779)

This ticket was mentioned in ​Slack in #accessibility by ryokuhi. ​View the logs.
2 years ago

#4 @sabernhardt
2 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 6.1
  • Version 5.9.3 deleted

@iamjaydip Could you remove the Customizer change and the extra space before maxlength from the pull request?

This ticket was mentioned in ​PR #2755 on ​WordPress/wordpress-develop by ​bhrugesh96.
2 years ago #5

  • Keywords needs-refresh removed

Fixed autocomplete attribute in the comment form - wp-includes/comment-template.php
Ref. (https://core.trac.wordpress.org/ticket/55779)

#6 @davidbaumwald
2 years ago

  • Owner set to davidbaumwald
  • Status changed from new to reviewing

#7 @davidbaumwald
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53576:

Comments: Add contextual autocomplete attributes to comment form fields.

For accessibility, input fields should identify their "purpose". The HTML5 attribute autocomplete allows for various user data to be quickly autofilled while adding context for some assistive technologies.

This commit adds the appropriate autofill purposes for an author's name, email, and website URL in the comment form template.

Props juliemoynat, bhrugesh96, sabernhardt.
Fixes #55779.

​dream-encode commented on ​PR #2739:
2 years ago #8

Thanks for the PR! This was merged into core in https://core.trac.wordpress.org/changeset/53576.

​dream-encode commented on ​PR #2755:
2 years ago #9

Thanks for the PR! This was merged into core in https://core.trac.wordpress.org/changeset/53576.

#10 @audrasjb
2 years ago

I'm working on the Week in Core blogpost and I noticed that @bhrugesh12 (dotorg profile) should receive props instead of bhrugesh96 (GH profile).

@davidbaumwald would you mind reattributing the props manually using the Core Props tool on Make/Core? Thanks!

Last edited 2 years ago by audrasjb (previous) (diff)

#11 @davidbaumwald
2 years ago

@audrasjb I went in to take care of it, but someone else already did. Sorry about that.

#12 @audrasjb
2 years ago

No worries, it happens!

These blogposts are at least useful to catch props mistakes :D

#13 @milana_cap
2 years ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.