Make WordPress Core

Opened 2 years ago

Closed 10 months ago

Last modified 9 months ago

#55784 closed enhancement (fixed)

TikTok Creator embed

Reported by: charlesnaa's profile charlesnaa Owned by: swissspidy's profile swissspidy
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch has-testing-info has-screenshots commit add-to-field-guide
Focuses: Cc:

Description (last modified by sabernhardt)

I noticed that TikTok supports creator embed now.
e.g. https://www.tiktok.com/embed/@taylorswift
And oembed works for it as well.
e.g. https://www.tiktok.com/oembed?url=https://www.tiktok.com/@bts_official_bighit

Can we extend the embed feature for TikTok creator embed as well?

Change History (13)

#1 @sabernhardt
2 years ago

  • Focuses accessibility removed

#2 @sabernhardt
2 years ago

  • Description modified (diff)

#3 @swissspidy
11 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 6.3

#5 @mukesh27
11 months ago

Thanks @swissspidy, The embed is working for https://www.tiktok.com/@taylorswift.

The PR #4525 is ready to go.

#6 @mukesh27
11 months ago

  • Owner set to swissspidy
  • Status changed from new to assigned

#7 @anveshika
11 months ago

Test Report

Env

  • WordPress - 6.3-alpha-20230531.115728
  • Firefox Version - 113.0.2 (64-bit)
  • OS - macOS
  • Theme: Twenty Twenty One
  • PHP - 7.4.0

Steps to test

  1. Go to WordPress Dashboard
  2. Go to "Pages", then "Add New".
  3. Click the "+" icon.
  4. Click 'Embed'.
  5. Enter the Tiktok embed URL like
    https://www.tiktok.com/@taylorswift
    
    https://www.tiktok.com/oembed?url=https://www.tiktok.com/@bts_official_bighit
    
  1. Wait for preview
  2. Publish the post/page

Test result

The test was conducted to verify the functionality of the TikTok Creator embed feature after recent code changes. TikTok Creator embed are working now with Embed block in WordPress editor.


Before-

https://i.imgur.com/HVPTFZU.jpg

After-

https://i.imgur.com/ni3DwE3.jpg

#8 @anveshika
11 months ago

  • Keywords has-testing-info has-screenshots added

#9 @Ankit K Gupta
11 months ago

I also tested the new changes on WP theme 2023 and PHP 8.1.

Test Report-

Tested Tiktok Profile Embed Functionality

Test Environment:

PHP version: 8.1
Theme: Twenty Twenty-Three Version: 1.1
Browser: Chrome 113

Test Result -

The test scenario involved testing the functionality of the Tiktok Profile Embed feature after the latest changes.
The Tiktok Profile Embed feature worked as expected without any issues. The embedded Tiktok profile was displayed correctly on the webpage, and all the expected functionalities, such as viewing videos and accessing profile information, were available and functional.

Screenshot -

https://i.imgur.com/9ZP0KsN.jpg

Last edited 11 months ago by Ankit K Gupta (previous) (diff)

#10 @mukesh27
11 months ago

  • Keywords commit added

Thanks for the testing report.

Ready for commit

#11 @swissspidy
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 55897:

Embeds: Add support for TikTok creator profiles.

Follow-up to initial support in [47216] / #49083.

Props mukesh27, anveshika, Ankit K Gupta.
Fixes #55784.

#13 @swissspidy
9 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.