Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#55793 closed defect (bug) (fixed)

Dashboard welcome panel image overlaps text in RTL

Reported by: ryelle's profile ryelle Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch dev-reviewed commit fixed-major
Focuses: rtl Cc:

Description

The "6.0" graphic is not repositioned when an RTL language is used, so the image ends up overlapping the heading & subtitle.

Attachments (3)

Screen Shot 2022-05-23 at 11.49.36.png (119.6 KB) - added by ryelle 2 years ago.
55793.diff (475 bytes) - added by ryelle 2 years ago.
Screen Shot 2022-05-23 at 11.39.46 AM.png (412.5 KB) - added by hellofromTonya 2 years ago.
Issue resolved after applying the patch.

Download all attachments as: .zip

Change History (12)

@ryelle
2 years ago

#1 @ryelle
2 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by costdev. View the logs.


2 years ago

#3 @hellofromTonya
2 years ago

  • Keywords commit dev-feedback has-testing-info added
  • Owner set to hellofromTonya
  • Status changed from new to reviewing

Test Report

Patch tested: 55793.diff

How to read this report:

✅ <= Behavior is expected.
❌ <= Behavior is NOT expected.

Environment

  • OS: macOS Big Sur
  • Web Server: wp-env
  • WordPress: 6.0 branch
  • Browser: Firefox 100.0
  • Theme: Twenty Twenty-Two
  • Active Plugins: None

Steps to Test Patch

  1. Go to Settings > General.
  2. Select a RTL language.
  3. Checkout the 6.0 branch.
  4. Go to Dashboard.
  5. Notice the header place.
  6. Applied the patch against the 6.0 branch
  7. Rebuilt via
    npm run build:dev
    npm run env:start
    npm run env:install
    
  8. Bust the browser cache.
  9. Check if the bug is resolved.

Test Results

  • 🐞 Can reproduce the bug
  • ✅ Issue resolved with patch.

@hellofromTonya
2 years ago

Issue resolved after applying the patch.

#4 @ironprogrammer
2 years ago

  • Keywords commit dev-feedback has-testing-info removed

Test Report

55793.diff

Report Legend:
✅ <= Behavior is expected.
❌ <= Behavior is NOT expected.

Environment

  • macOS 12.3.1
  • PHP 7.4.29
  • WordPress 6.1-alpha-53344-src
  • Safari 15.4
  • Google Chrome 101.0.4951.64

Steps to Test Patch

  1. Navigate to Settings > General and set the Site Language to a RTL language (e.g. Persian or Arabic).
  2. Navigate to Dashboard > Home.
  3. 🐞 Observe that the "6.0" image appears under the welcome box text, obscuring the text.
  4. 🛠 Apply patch. Rebuild the site CSS as necessary (e.g. for wordpress-develop, run npm run build:dev). In the browser, force a hard cache reset to load the updated CSS.
  5. Refresh the Dashboard > Home page.
  6. ✅ Observe that the "6.0" image is positioned to the left of the welcome box, and not obscured by inline text.

Expected Results

  • ✅ Bug was reproduced successfully.
  • ✅ The patch addressed the reported issue.

Screenshots

Before Patch:
https://cldup.com/M_CVWLTSPe.png

After Patch:
https://cldup.com/liO-UfECM0.png

#5 @ryelle
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53437:

Administration: Fix image overlap in Dashboard welcome panel.

Use longhand positioning properties (top, right, etc) so that the rtlcss build process can correctly adjust the layout for the RTL CSS.

Props ryelle, costdev, ironprogrammer, hellofromtonya.
Fixes #55793.

#6 @ryelle
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @hellofromTonya
2 years ago

  • Keywords dev-reviewed commit added; fixed-major removed

Marking [53437] okay for backport.

#8 @hellofromTonya
2 years ago

  • Keywords fixed-major added

Whoopsie didn't mean to remove fixed-major keyword.

#9 @ryelle
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 53438:

Administration: Fix image overlap in Dashboard welcome panel.

Use longhand positioning properties (top, right, etc) so that the rtlcss build process can correctly adjust the layout for the RTL CSS.

Props ryelle, costdev, ironprogrammer, hellofromtonya.
Merges [53437] to the 6.0 branch.
Fixes #55793.

Note: See TracTickets for help on using tickets.