Media help tab missing info on “Copy URL to clipboard“

[kebbet]

This is a follow up to [52842].

The help tab in wp-admin/upload.php is missing info on the new row action. In addition to adding info on Copy URL to clipboard, the patch also enhance the Avalible actions-tab with a list with each row action. (Inspiration from wp-admin/users.php)

Setting version to Trunk since 6.0 does not exist.

[costdev]

Test Report

55800-upload-php-help-info.diff

Report Legend:
✅ <= Behavior is expected.
❌ <= Behavior is NOT expected.

Environment

• Server: Apache (Linux)
• WordPress: 6.1-alpha-53344-src
• Browser: Chrome 101.0.4951.64
• OS: Windows 10
• Theme: Twenty Twenty-Two
• Plugins: None activated

Steps to Test Patch

1. Navigate to Media > Library.
2. Click the Help tab.
3. Click Available actions.
4. 🐞 Observe that the UI copy does not include information for the Edit, Delete permanently, View and Copy URL to clipboard actions.
5. 🛠 Apply the patch.
6. Refresh the Media > Library page, click the Help tab, followed by Available actions.
7. ✅ Observe that the UI copy now includes information for the Edit, Delete permanently, View and Copy URL to clipboard actions.

Results

• ✅ Issue was reproduced successfully.
• ✅ The patch addressed the reported issue.
• ❌ There is a period . missing from the Edit action.

[costdev]

Added missing period on "Edit" action.

[SergeyBiryukov]

Hi there, thanks for the patch!

It looks good to me but appears to introduce five new strings. I think we generally try to minimize string changes in minor releases. Any objections to moving this to 6.1, along with #55801?

On second thought, a few string changes in a minor release might be fine, but I would ideally like to get some feedback from the Polyglots team on this.

[kebbet]

Before patch applied

[kebbet]

After patch applied

[mukesh27]

Hi there! Thanks for the patch.

Patch LGTM. Can we use direct content instead of adding the $help variable as consistency in core ​https://github.com/WordPress/WordPress/blob/master/wp-admin/edit.php#L265-L272?

Trac ticket: https://core.trac.wordpress.org/ticket/55800

[kebbet]

Used $help with inspiration from ​https://github.com/WordPress/WordPress/blob/master/wp-admin/users.php#L53-L63 but your comment makes sense in this case. There is no need to use variables in this file.

[audrasjb]

Added a follow-up commit to the proposed PR to fix a WPCS issue (space used instead of tab).
The patch looks good to me, thanks!

[kebbet]

To test this patch, make sure to visit /wp-admin/upload.php?mode=list, the so called List View in the Media Library.

[audrasjb]

Replying to SergeyBiryukov:

It looks good to me but appears to introduce five new strings. I think we generally try to minimize string changes in minor releases. Any objections to moving this to 6.1, along with #55801?

I think you're right, there's no urgent need for this to be fixed in the next minor.
Moving to milestone 6.1. We can still move it back to 6.0.x later if needed.

[audrasjb]

Alright, the PR looks good to me. I think it's good to go.

[audrasjb]

In 53586:

Help/About: Add help tab info for available row actions in the Media Library.

This changeset fills the existing help tab with more detailed information about available row actions in the Media Library, when using the List view.

Props kebbet, audrasjb, costdev, SergeyBiryukov, mukesh27.
Fixes #55800.

Committed in https://core.trac.wordpress.org/changeset/53586

[SergeyBiryukov]

Edit takes you to simple screen

Should this be "takes you to a simple screen"?

[kebbet]

Replying to SergeyBiryukov:

Edit takes you to simple screen

Should this be "takes you to a simple screen"?

Yes, my bad.

[audrasjb]

Oh yes thanks for catching this. On it.

[audrasjb]

In 53587:

Help/About: Typo correction in the Media Library help tab text.

Follow-up to [53586].

Props SergeyBiryukov.
Fixes #55800.