Make WordPress Core

Opened 23 months ago

Closed 22 months ago

Last modified 19 months ago

#55800 closed defect (bug) (fixed)

Media help tab missing info on “Copy URL to clipboard“

Reported by: kebbet's profile kebbet Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version: 6.0
Component: Media Keywords: has-patch has-testing-info has-screenshots commit needs-user-docs
Focuses: docs, ui-copy Cc:

Description

This is a follow up to [52842].

The help tab in wp-admin/upload.php is missing info on the new row action. In addition to adding info on Copy URL to clipboard, the patch also enhance the Avalible actions-tab with a list with each row action. (Inspiration from wp-admin/users.php)

Setting version to Trunk since 6.0 does not exist.

Attachments (4)

55800-upload-php-help-info.diff (1.8 KB) - added by kebbet 23 months ago.
55800.1.diff (1.8 KB) - added by costdev 23 months ago.
Added missing period on "Edit" action.
55800-before.png (98.8 KB) - added by kebbet 23 months ago.
Before patch applied
55800-after.png (134.3 KB) - added by kebbet 23 months ago.
After patch applied

Download all attachments as: .zip

Change History (24)

#1 @costdev
23 months ago

Test Report

55800-upload-php-help-info.diff

Report Legend:
✅ <= Behavior is expected.
❌ <= Behavior is NOT expected.

Environment

  • Server: Apache (Linux)
  • WordPress: 6.1-alpha-53344-src
  • Browser: Chrome 101.0.4951.64
  • OS: Windows 10
  • Theme: Twenty Twenty-Two
  • Plugins: None activated

Steps to Test Patch

  1. Navigate to Media > Library.
  2. Click the Help tab.
  3. Click Available actions.
  4. 🐞 Observe that the UI copy does not include information for the Edit, Delete permanently, View and Copy URL to clipboard actions.
  5. 🛠 Apply the patch.
  6. Refresh the Media > Library page, click the Help tab, followed by Available actions.
  7. ✅ Observe that the UI copy now includes information for the Edit, Delete permanently, View and Copy URL to clipboard actions.

Results

  • ✅ Issue was reproduced successfully.
  • ✅ The patch addressed the reported issue.
  • ❌ There is a period . missing from the Edit action.

@costdev
23 months ago

Added missing period on "Edit" action.

#2 @costdev
23 months ago

  • Keywords has-testing-info added
  • Milestone changed from Awaiting Review to 6.0.1

#3 follow-up: @SergeyBiryukov
23 months ago

Hi there, thanks for the patch!

It looks good to me but appears to introduce five new strings. I think we generally try to minimize string changes in minor releases. Any objections to moving this to 6.1, along with #55801?

On second thought, a few string changes in a minor release might be fine, but I would ideally like to get some feedback from the Polyglots team on this.

@kebbet
23 months ago

Before patch applied

@kebbet
23 months ago

After patch applied

This ticket was mentioned in Slack in #polyglots by kebbet. View the logs.


23 months ago

#5 @mukesh27
23 months ago

Hi there! Thanks for the patch.

Patch LGTM. Can we use direct content instead of adding the $help variable as consistency in core https://github.com/WordPress/WordPress/blob/master/wp-admin/edit.php#L265-L272?

#7 @kebbet
23 months ago

Used $help with inspiration from https://github.com/WordPress/WordPress/blob/master/wp-admin/users.php#L53-L63 but your comment makes sense in this case. There is no need to use variables in this file.

#8 @audrasjb
22 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Added a committed to the proposed PR to fix a WPCS issue (space used instead of tab).
The patch looks good to me, thanks!

Version 0, edited 22 months ago by audrasjb (next)

This ticket was mentioned in Slack in #core-test by ironprogrammer. View the logs.


22 months ago

#10 @ironprogrammer
22 months ago

  • Keywords has-screenshots added

#11 @kebbet
22 months ago

To test this patch, make sure to visit /wp-admin/upload.php?mode=list, the so called List View in the Media Library.

#12 in reply to: ↑ 3 @audrasjb
22 months ago

  • Milestone changed from 6.0.1 to 6.1

Replying to SergeyBiryukov:

It looks good to me but appears to introduce five new strings. I think we generally try to minimize string changes in minor releases. Any objections to moving this to 6.1, along with #55801?

I think you're right, there's no urgent need for this to be fixed in the next minor.
Moving to milestone 6.1. We can still move it back to 6.0.x later if needed.

#13 @audrasjb
22 months ago

  • Keywords commit added

Alright, the PR looks good to me. I think it's good to go.

#14 @audrasjb
22 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53586:

Help/About: Add help tab info for available row actions in the Media Library.

This changeset fills the existing help tab with more detailed information about available row actions in the Media Library, when using the List view.

Props kebbet, audrasjb, costdev, SergeyBiryukov, mukesh27.
Fixes #55800.

#16 follow-up: @SergeyBiryukov
22 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Edit takes you to simple screen

Should this be "takes you to a simple screen"?

#17 in reply to: ↑ 16 @kebbet
22 months ago

Replying to SergeyBiryukov:

Edit takes you to simple screen

Should this be "takes you to a simple screen"?

Yes, my bad.

#18 @audrasjb
22 months ago

Oh yes thanks for catching this. On it.

#19 @audrasjb
22 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 53587:

Help/About: Typo correction in the Media Library help tab text.

Follow-up to [53586].

Props SergeyBiryukov.
Fixes #55800.

#20 @milana_cap
19 months ago

  • Keywords needs-user-docs added
Note: See TracTickets for help on using tickets.