Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #55883, comment 21


Ignore:
Timestamp:
09/22/2022 07:23:04 PM (21 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #55883, comment 21

    v2 v3  
    33Is `apply_shortcodes()` really that much better (in plain English) than `do_shortcode()`. Is it really worth it breaking all references to `do_shortcode` just for the sake of changing `do` with `apply`? I think not.
    44
    5 `do_shortcode` has existed for many many years. It is referenced in a lot of places, online documentation, many posts, thousands of themes and plugins, many books, etc. Why would WordPress want to break all these references? It is the same as breaking links, bad UX and brings a lot of confusion.
     5`do_shortcode` has existed for many many years. It is referenced in a lot of places, online documentation, many posts, thousands of themes and plugins, many books, etc. Why would WordPress want to break all these references? It is the same as breaking links, very bad UX.
    66
    7 I think it is a pretty bad idea to create all that confusion and broken references for such a minor benefit. A much better solution imho would be to update the docs, add as much content there as needed. That will serve all existing WP contributors and help all new contributors, and most importantly, will not break any links and references.
     7I think it is a pretty bad idea to create all that confusion and broken references for such a minor benefit. A much better solution imho would be to update the docs, add as much content there as needed. That will serve all existing WP contributors and help all new contributors, and most importantly, will not break any links and cause confusion.
    88
    9 Also I'm not sure if the `apply_shortcodes` alias was needed in the first place. Seems the adoption is pretty low? Also the meaning in plain English is so close that only way to classify it would be as "very minor enhancement". That alias probably just brings some confusion for new users.
     9Also I'm not sure if the `apply_shortcodes` alias was needed in the first place. It's been around for couple of years, since WP 5.4, but seems the adoption is pretty low? Think it can be classified as an "unsuccessful experiment" at this point. A quick search shows 134 matches in plugins for `apply_shortcodes` versus 38653 matches for `do_shortcode`. See https://wpdirectory.net/search/01GDK9ZK4WX0KQT21ZS28K9E06 and https://wpdirectory.net/search/01GDKA13MP0C6FKDYXWHPPXQ9P. That alias probably just brings some confusion for new contributors.
    1010
    1111I'd like to propose that this is reverted and closed. This type of name changes is not worth the trouble and confusion they bring imho.