False is not a valid cache key in community-events

[malthert]

There is a check for this in 1 place, but it's missing in the other, causing issues, since you pass an invalid type to get_site_transient

Add check for false transient key, which is not a valid key.
There already is a check in the other place in this file where this is used. Added it in all places now.

Trac ticket: https://core.trac.wordpress.org/ticket/55888#ticket

[rafiahmedd]

2nd opinion.

[malthert]

Early return is better and also it's more in the style of the existing check of line 337

[audrasjb]

Reviewed during today's bug scrub.

The patch doesn’t look bad, but I’d say the last comment would probably provide a better approach for this (early return when falsey transient key).

[costdev]

Calling get_site_transient( false ) doesn't cause any notices/warning/errors. What am I missing?

[malthert]

@costdev I can't remember it's been a while and I don't have time to dive into it atm, but since the function arg is string, we shouldn't pass a bool at least.

[davidbaumwald]

In 54338:

Administration: Guard against false transient key in get_cached_events().

Inside WP_Community_Events::get_cached_events(), WP_Community_Events::get_events_transient_key() is used to retrieve the transient key name, based on the user's location. However, the transient key can potentially return false, resulting in a call to get_site_transient() with the $key being false.

This change first attempts to evaluate and guard against a false return from WP_Community_Events::get_events_transient_key(). The result is an early false return from WP_Community_Events::get_cached_events().

Props malthert, rafiahmedd, audrasjb, costdev.
Fixes #55888.

Thanks for the PR! This was merged in r54338.