Make WordPress Core

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#55903 closed defect (bug) (fixed)

Update readme with the right nodejs version commands

Reported by: elpanda13gmailcom's profile elpanda13@… Owned by: desrosj's profile desrosj
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description

IN https://github.com/WordPress/wordpress-develop one of the first steps is to install NodeJS, however this project runs on node 14 and with the command explained in the readme file you'd end up installing the latest version (current 18) which will end up throwing a LOT of errors when running npm "install" or "build" commands.

Change History (18)

#1 @desrosj
22 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 6.1
  • Owner set to desrosj
  • Severity changed from major to normal
  • Status changed from new to assigned

Thanks for flagging this, @elpanda13gmailcom. And welcome to Trac!

I think this is a good thing to call out. Maybe something like: **Note:** WordPress currently only supports up to NodeJS 14.x and npm < 7. after the NodeJS instructions.

Also, a few related tickets that will focus on bringing Core to a compatible state with the latest LTS of NodeJS: #56658, #52951.

I'm marking this as a good-first-bug, and also have moved it to the 6.1 milestone.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


22 months ago

This ticket was mentioned in PR #3335 on WordPress/wordpress-develop by jakariaistauk337.


22 months ago
#3

  • Keywords has-patch added; needs-patch removed

Trac ticket: #55903

#4 @robinwpdeveloper
22 months ago

Thanks @elpanda13gmailcom for finding this out!

akashmdiu commented on PR #3335:


22 months ago
#5

It looks good to me for Windows OS.
https://i0.wp.com/user-images.githubusercontent.com/31040302/192435438-33625ae2-c0a0-4454-ab23-8e5d049a0f77.png

rudlinkon commented on PR #3335:


22 months ago
#6

Thank you @jakariaistauk337 and welcome to trac
Looks good to me for MAC.

fuadragib01 commented on PR #3335:


22 months ago
#7

Looks good to me as windows user
https://i0.wp.com/user-images.githubusercontent.com/18370135/192440158-8861a2be-0fdc-4fec-8a9d-530dafefede2.PNG

mukeshpanchal27 commented on PR #3335:


22 months ago
#8

@jakariaistauk337 Left one comment for the command format. Use indention for the comment list instead of the number and &nbsp;

#9 @mukesh27
22 months ago

  • Keywords changes-requested added

Hi there!

I requested some changes that make document better for visibility.

robinwpdeveloper commented on PR #3335:


22 months ago
#10

Yes. Indention would be better instead of &nbsp;

jakariaistauk337 commented on PR #3335:


22 months ago
#11

@jakariaistauk337 Left one comment for the command format. Use indention for the comment list instead of the number and &nbsp;

thank you @mukeshpanchal27 for the suggestion. Thats looks cool now

#12 @hztyfoon
22 months ago

Thanks @elpanda13gmailcom for finding it.
The PR looks good. I just requested slight change in the note @jakariaistauk.

#13 @desrosj
22 months ago

  • Status changed from assigned to reviewing

#14 @desrosj
22 months ago

  • Keywords needs-user-docs removed

Added notes to the PR.

#15 @desrosj
22 months ago

  • Keywords commit added; changes-requested removed

Going to make some slight adjustments pre-commit.

#16 @desrosj
22 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54375:

Build/Test Tools: Note the versions of NodeJS and npm supported.

This adds a note to the Getting Started section of the README.md file mentioning that NodeJS 14.x and npm 6.x is currently required to spin up a development environment.

Props elpanda13gmailcom, robinwpwebdeveloper, jakariaistauk, hztyfoon, seakashdiu, rudlinkon, fuadragib.
Fixes #55903.

#18 @desrosj
22 months ago

I missed @mukesh27 in the props and miscredited @robinwpdeveloper, but I've gone and corrected this manually and props are now showing on your .org profiles correctly.

Note: See TracTickets for help on using tickets.