WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #55966, comment 20


Ignore:
Timestamp:
09/07/2022 03:45:23 PM (15 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #55966, comment 20

    initial v1  
    44Thanks! [attachment:"55966.4.diff"] looks good to me.
    55
    6 I had to revert the original commit for now due the `WP_Theme_JSON::remove_insecure_properties()` test failures, see comment:17. Remove those tests did not seem like the correct approach, I think they would need some new examples of unsafe values. Let's address that and re-commit the patch :)
     6I had to revert the original commit for now due the `WP_Theme_JSON::remove_insecure_properties()` test failures, see comment:17. Removing those tests did not seem like the correct approach, I think they would need some new examples of unsafe values. Let's address that and re-commit the patch :)