Make WordPress Core

Opened 3 years ago

Closed 10 months ago

#55975 closed defect (bug) (fixed)

Twenty Twenty: Pullquote Block font-size issue

Reported by: kmadhak's profile kmadhak Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: normal Version: 6.0
Component: Bundled Theme Keywords: has-patch needs-testing commit
Focuses: ui, css Cc:

Description

When we choose a Pullquote block in editor side and change the font-size of "Add Quote" and "Add Citation" text then it is not reflected.

Steps to replicate:

1: Activate the Twenty Twenty Theme
2: Add Pullquote block
3: Add "Add Quote" text and "Add Citation" text
4: Choose Typography Size Option

for more information I provided a video
Video: https://share.cleanshot.com/YFEvesCAX75U534X1xXR

Thank you.

Attachments (4)

55975.patch (1.6 KB) - added by nidhidhandhukiya 3 years ago.
after applying this solution issue is resolved.
55975.1.patch (1015 bytes) - added by sabernhardt 11 months ago.
inherits font size when the block has custom class or inline style (on front end)
55975.2.patch (1.4 KB) - added by shailu25 11 months ago.
Patch Updated
55975.3.patch (2.7 KB) - added by shailu25 11 months ago.
Updated patch.

Download all attachments as: .zip

Change History (20)

#1 @SergeyBiryukov
3 years ago

  • Summary changed from Twenty Twenty:- Pullquote Block font-size issue to Twenty Twenty: Pullquote Block font-size issue

@nidhidhandhukiya
3 years ago

after applying this solution issue is resolved.

#2 @nidhidhandhukiya
3 years ago

  • Keywords has-patch has-unit-tests needs-testing added; needs-patch removed

#3 @harshvaishnav
3 years ago

  • Keywords needs-testing removed

I have reproduced this issue on WP 6.0 and the issue is resolved with the given patch and works fine. Checked this issue on cross browsers as well and it is working well with latest versions of chrome, safari and fire fox.

Steps to reproduce:
1: Activate the Twenty Twenty Theme on WP 6.0
2: Add 'Pullquote' block
3: Add "Add Quote" text and "Add Citation" text
4: Choose Typography Size Option and change font size

For better understanding, please find below attached video explanation:
Video: https://screencast-o-matic.com/watch/c31Di6V35GA

Thank you.

Last edited 3 years ago by harshvaishnav (previous) (diff)

#4 @sabernhardt
17 months ago

#56871 was marked as a duplicate.

#5 @sabernhardt
17 months ago

#60339 was marked as a duplicate.

#6 @sabernhardt
17 months ago

  • Keywords has-unit-tests removed

@sabernhardt
11 months ago

inherits font size when the block has custom class or inline style (on front end)

#7 @sabernhardt
11 months ago

  • Milestone changed from Awaiting Review to Future Release

I did not find a need to update the editor styles, but the patch sets the Pullquote block's paragraph to inherit its font size from the block setting (and keep the default as it is).

@shailu25
11 months ago

Patch Updated

#8 @shailu25
11 months ago

55975.1.patch is Working fine & Font issue is resolved with patch.

However, there are still issues with letter spacing and font weight on the frontend. Therefore, I have updated the patch.

#9 @karmatosed
11 months ago

  • Keywords needs-testing added

#10 @karmatosed
11 months ago

Let's get some testing on this as we seem to have two patches going on @sabernhardt and @shailu25 if you can confirm which you want going forward after testing please.

#11 @sabernhardt
11 months ago

55975.2.patch increases the scope of the ticket, but it would be nice to adjust for all three properties in the same commit.

Could you make a few changes?

  • The new front-end styles would belong a few lines earlier, before the "Solid Background Color" comment.
  • The Pullquote section of editor-style-block.css could add a rule to account for custom Letter Spacing in the editor (possibly before the .editor-styles-wrapper .wp-block-pullquote__citation line).

#12 @shailu25
11 months ago

Yes, I Will update the patch.

@shailu25
11 months ago

Updated patch.

#13 @shailu25
11 months ago

I have updated the patch to include both changes as suggested in the above comment.)

#14 @karmatosed
10 months ago

  • Owner set to karmatosed
  • Status changed from new to assigned

Thank you everyone. I am going to test this and see about progressing the journey of this ticket.

#15 @karmatosed
10 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 6.7

I can confirm this patch works so going to look to commit, thanks everyone.

#16 @karmatosed
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58908:

Twenty Twenty: Fixes pullquote block font size not changing.

The pullquote block was not reflecting the size changes. This also accounts for letter spacing in the editor.

Props kmadhak, SergeyBiryukov, nidhidhandhukiya, harshvaishnav, sabernhardt, shailu25.
Fixes #55975.

Note: See TracTickets for help on using tickets.