Opened 2 years ago
Closed 8 weeks ago
#55975 closed defect (bug) (fixed)
Twenty Twenty: Pullquote Block font-size issue
Reported by: | kmadhak | Owned by: | karmatosed |
---|---|---|---|
Milestone: | 6.7 | Priority: | normal |
Severity: | normal | Version: | 6.0 |
Component: | Bundled Theme | Keywords: | has-patch needs-testing commit |
Focuses: | ui, css | Cc: |
Description
When we choose a Pullquote block in editor side and change the font-size of "Add Quote" and "Add Citation" text then it is not reflected.
Steps to replicate:
1: Activate the Twenty Twenty Theme
2: Add Pullquote block
3: Add "Add Quote" text and "Add Citation" text
4: Choose Typography Size Option
for more information I provided a video
Video: https://share.cleanshot.com/YFEvesCAX75U534X1xXR
Thank you.
Attachments (4)
Change History (20)
#1
@
2 years ago
- Summary changed from Twenty Twenty:- Pullquote Block font-size issue to Twenty Twenty: Pullquote Block font-size issue
#3
@
2 years ago
- Keywords needs-testing removed
I have reproduced this on WP 6.0 and the issue is resolved with the given patch and works fine. Checked this issue on cross browsers as well and it is working well with latest versions of chrome, safari and fire fox.
Steps to reproduce:
1: Activate the Twenty Twenty Theme on WP 6.0
2: Add 'Pullquote' block
3: Add "Add Quote" text and "Add Citation" text
4: Choose Typography Size Option and change font size
For better understanding, please find below attached video explanation:
Video: https://screencast-o-matic.com/watch/c31Di6V35GA
Thank you.
#7
@
3 months ago
- Milestone changed from Awaiting Review to Future Release
I did not find a need to update the editor styles, but the patch sets the Pullquote block's paragraph to inherit its font size from the block setting (and keep the default as it is).
#8
@
3 months ago
55975.1.patch is Working fine & Font issue is resolved with patch.
However, there are still issues with letter spacing and font weight on the frontend. Therefore, I have updated the patch.
#10
@
3 months ago
Let's get some testing on this as we seem to have two patches going on @sabernhardt and @shailu25 if you can confirm which you want going forward after testing please.
#11
@
3 months ago
55975.2.patch increases the scope of the ticket, but it would be nice to adjust for all three properties in the same commit.
Could you make a few changes?
- The new front-end styles would belong a few lines earlier, before the "Solid Background Color" comment.
- The Pullquote section of
editor-style-block.css
could add a rule to account for custom Letter Spacing in the editor (possibly before the.editor-styles-wrapper .wp-block-pullquote__citation
line).
#13
@
3 months ago
I have updated the patch to include both changes as suggested in the above comment.)
#14
@
2 months ago
- Owner set to karmatosed
- Status changed from new to assigned
Thank you everyone. I am going to test this and see about progressing the journey of this ticket.
after applying this solution issue is resolved.