Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #55985, comment 82


Ignore:
Timestamp:
02/06/2023 04:16:56 PM (2 years ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #55985, comment 82

    initial v1  
    11Notes for pull requests 3992 to 3997:
    22
    3 1. To avoid errors in the block editor with the more recent five themes, the theme directory is removed from the function output in `add_editor_style`. Making the stylesheet relative gives a `baseURL` for the relative font URLs in the stylesheet so the editor does not try loading them from the `wp-admin` directory. If anyone has replaced the theme setup function from Twenty Fourteen, Twenty Fifteen or Twenty Sixteen, that child theme would need updating.
     31. To avoid errors in the block editor with the more recent five themes, the theme directory is removed from the function output in `add_editor_style`. Making the stylesheet relative gives a `baseURL` for the relative font URLs in the stylesheet so the editor does not try loading them from the `wp-admin` directory. If anyone has replaced the theme setup function from Twenty Fourteen, Twenty Fifteen or Twenty Sixteen, that child theme (likely) would need updating.
    442. License information at the top of LICENSE.txt files is similar to what is in Twenty Twenty-Two. The README files also include copyright and licensing information, consistent with other themes.
    553. These font filenames would not change with any future updates, though the PRs include version numbers for the font files and the stylesheets. If instead we prefer to leave the stylesheet version as `null` and remove the query strings, visitors probably would not mind reusing the cached version of either the stylesheet or font files (if/when we update them). Without the query strings, updating fonts could be a little simpler, too.