Make WordPress Core

Opened 12 months ago

Closed 9 months ago

#55987 closed defect (bug) (fixed)

Twenty Twenty: Remove Left Padding in Social icon block in editor

Reported by: umesh84's profile umesh84 Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version: 6.0
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: ui, css Cc:

Description

In the Twenty Twenty Themes Need Remove Left Padding in Social Icon block in editor

Steps to replicate:

1: Activate the Twenty Twenty Themes
2: Add Social Icon block
3: See issue

Attachments (6)

Screenshot 2022-06-16 at 12.56.27 PM.png (326.1 KB) - added by umesh84 12 months ago.
For better understanding I have attached a screenshot
55987.patch (546 bytes) - added by umesh84 12 months ago.
added patch
55987.1.patch (1.1 KB) - added by nidhidhandhukiya 12 months ago.
Yes @audrasjb if we apply this solution then we have removed the padding from all the list i have added another solution for this issue after applying my solution only the social icon ul padding is removed.
#55987.patch (1.1 KB) - added by kajalgohel 12 months ago.
added patch for removing padding-left from social media block
Capture d’écran 2022-09-14 à 11.51.27.png (342.0 KB) - added by audrasjb 9 months ago.
Before patch
ce7232c2a949b40c63b962e0837f5cfe.gif (498.8 KB) - added by audrasjb 9 months ago.
After patch

Download all attachments as: .zip

Change History (12)

@umesh84
12 months ago

For better understanding I have attached a screenshot

@umesh84
12 months ago

added patch

#1 @audrasjb
12 months ago

  • Keywords changes-requested added; needs-patch removed

Hello and thanks for the patch!
However, I'm afraid this change will also remove the left padding on other lists.
This CSS rule should probably specifically target the Social icons block.

@nidhidhandhukiya
12 months ago

Yes @audrasjb if we apply this solution then we have removed the padding from all the list i have added another solution for this issue after applying my solution only the social icon ul padding is removed.

@kajalgohel
12 months ago

added patch for removing padding-left from social media block

#2 @kajalgohel
12 months ago

  • Keywords has-patch added

#3 @SergeyBiryukov
12 months ago

  • Milestone changed from Awaiting Review to 6.1
  • Summary changed from Twenty Twenty Themes Need Remove Left Padding in Social icon block in editor to Twenty Twenty: Remove Left Padding in Social icon block in editor

#4 @audrasjb
9 months ago

  • Keywords commit added; changes-requested removed

The last patch looks good to me. Self assigning for commit.

#5 @audrasjb
9 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#6 @audrasjb
9 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 54152:

Twenty Twenty: Correctly align Social Icons block in the editor.

This changeset resets padding-left property for the Social Icons block in the editor.

Props umesh84, audrasjb, nidhidhandhukiya, kajalgohel.
Fixes #55987.

Note: See TracTickets for help on using tickets.