Make WordPress Core

#55989 closed defect (bug) (fixed)

Twenty Twenty One: Text color not reflected in Editor for citation in Quote block

Reported by: jyolsna's profile jyolsna Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: ui, css Cc:

Description

Hello Team,

In Twenty Twenty One Theme when we select Quote block and add text color, it is not reflected for citation in the editor. But color change is reflected in the front end.

How to Replicate:

  1. Activate the Twenty Twenty One theme
  2. Insert Quote block
  3. Enter text and select color

https://www.loom.com/share/34744a72bf71449390db9983df7aa2f5

Attachments (4)

55989.diff (1.0 KB) - added by evildon 18 months ago.
Fix Quote citation colour not reflecting in backend editor (when main quote colour is changed)
#55989.patch (636 bytes) - added by kajalgohel 18 months ago.
added patch for adding color of citation text in editor side
c023d1542c202e2ef17573861441ead1.gif (910.9 KB) - added by audrasjb 18 months ago.
Patch fixes the issue
53-editor.png (370.2 KB) - added by poena 18 months ago.
Quote block with cite in dark mode and with white background, WordPress 5.3

Download all attachments as: .zip

Change History (16)

@evildon
18 months ago

Fix Quote citation colour not reflecting in backend editor (when main quote colour is changed)

#1 follow-up: @audrasjb
18 months ago

  • Focuses ui css added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 6.1
  • Owner set to audrasjb
  • Status changed from new to reviewing
  • Version 6.0 deleted

Thanks for the ticket and welcome to WordPress Core Trac @jyolsna,

Self assigning for review.

@kajalgohel
18 months ago

added patch for adding color of citation text in editor side

#2 in reply to: ↑ 1 @jyolsna
18 months ago

Replying to audrasjb:

Thanks for the ticket and welcome to WordPress Core Trac @jyolsna,

Self assigning for review.

Happy to contribute to WordPress! Thanks for the warm welcome and review.

#3 @SergeyBiryukov
18 months ago

  • Summary changed from Twenty Twenty One - Text color not reflected in Editor for citation in Quote block to Twenty Twenty One: Text color not reflected in Editor for citation in Quote block

@audrasjb
18 months ago

Patch fixes the issue

#4 @audrasjb
18 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53517:

Twenty Twenty-One: Ensure custom text color is reflected in the Editor for Quote block.

This changes removes an hardcoded CSS color value for the Quote block in Twenty Twenty-One's editor stylesheet. This ensures custom text color is fully reflected in the Editor for Quote block.

Props jyolsna, evildon, kajalgohel, audrasjb.
Fixes #55989.

#5 @poena
18 months ago

Hi!
Was this color change tested on all supported WordPress versions _even those without color options for the quote block_ and with the dark mode enabled?

Last edited 18 months ago by poena (previous) (diff)

#6 @poena
18 months ago

Test results:

This works on 5.3 because the primary color is also set on
blockquote .wp-block-quote__citation in assets/sass/04-elements/blockquote.scss


-Will the remaining CSS files not be built before the release of the theme update?

@poena
18 months ago

Quote block with cite in dark mode and with white background, WordPress 5.3

#7 @audrasjb
18 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to make sure we check and address the above potential issue.

#8 @poena
18 months ago

5.4, 5.5, 5.6, 5.7, 5.8: Works the same as in 5.3.
Well done everyone :)

#9 @desrosj
17 months ago

In 53739:

Twenty Twenty-One: Rebuild the IE specific stylesheet.

This was missed in [53517].

See #55989.

This ticket was mentioned in Slack in #core by chaion07. View the logs.


14 months ago

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


14 months ago

#12 @desrosj
14 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This was waiting for testing on different versions of WordPress, which @poena detailed her findings doing above.

Closing out as fixed.

Note: See TracTickets for help on using tickets.