Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55992 closed defect (bug) (fixed)

Twenty Nineteen: Text color not reflected in Editor for citation in Quote block

Reported by: nithi22's profile nithi22 Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots commit
Focuses: ui, css Cc:

Description

In Twenty Nineteen Theme when we select Quote block and add text color, it is not reflected for citation in the editor. But color change is reflected in the front end.

How to Replicate:

  1. Activate the Twenty Nineteen theme
  2. Insert Quote block
  3. Enter text and select color

https://www.loom.com/share/fdc997b7f962453eaab516c0a9684cb7

Attachments (2)

55992.diff (1.0 KB) - added by evildon 2 years ago.
Fix quote citation text colour not reflecting in editor
d89961fc865b3fecf1194596f1f4675f.gif (666.9 KB) - added by audrasjb 2 years ago.

Download all attachments as: .zip

Change History (7)

@evildon
2 years ago

Fix quote citation text colour not reflecting in editor

#1 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.1
  • Summary changed from Twenty Nineteen - Text color not reflected in Editor for citation in Quote block to Twenty Nineteen: Text color not reflected in Editor for citation in Quote block

#2 follow-up: @audrasjb
2 years ago

  • Keywords has-patch has-screenshots commit added

@evildon's patch looks good to me and solves this small issue.
Just noting it's always better to generate it against the root of your wordpress-develop folder, so it's easier to apply.

#3 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#4 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53515:

Twenty Nineteen: Ensure custom text color is reflected in the Editor for Quote block.

This changes removes an hardcoded CSS color value for the Quote block in Twenty Nineteen's editor stylesheet. This ensures custom text color is fully reflected in the Editor for Quote block.

Props nithi22, evildon, SergeyBiryukov, audrasjb.
Fixes #55992.

#5 in reply to: ↑ 2 @evildon
2 years ago

Replying to audrasjb:

@evildon's patch looks good to me and solves this small issue.
Just noting it's always better to generate it against the root of your wordpress-develop folder, so it's easier to apply.

Thanks, Sure will keep it in mind

Note: See TracTickets for help on using tickets.