WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#55997 closed task (blessed) (fixed)

Remove meetup from oembed allow list

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: audrasjb's profile audrasjb
Milestone: 6.0.1 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch needs-dev-note needs-user-docs commit fixed-major
Focuses: Cc:

Description

Meetup.com have deprecated their oembed endpoint and will need to be removed from the allow list in WP Core.

The block has already been removed from the editor, see ​GB#35085.

Change History (14)

This ticket was mentioned in ​PR #2822 on ​WordPress/wordpress-develop by ​audrasjb.
2 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/55997

#2 @audrasjb
2 years ago

Makes sense to me. The PR above deprecates the endpoint.

#3 @audrasjb
2 years ago

  • Keywords needs-dev-note needs-user-docs added

#4 @swissspidy
2 years ago

It's really unfortunate that this was not brought up here on Trac sooner :( Considering this was fixed in Gutenberg already 8 months ago. Not the best information flow.

Anyway, the patch looks good to me.

#5 @peterwilsoncc
2 years ago

  • Keywords commit added

#6 follow-up: @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

Self assigning for commit right now.

Worth noting it's also possible to backport this to the next minor, since the endpoint doesn't work anymore.

#7 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53540:

Embeds: Remove Meetup as an oEmbed source since the related endpoint has been deprecated.

This changeset removes Meetup as an oEmbed source, since Meetup.com have deprecated their oEmbed endpoint. The block has already been removed from the editor, see GB#35085.

Props peterwilsoncc, audrasjb, swissspidy.
Fixes #55997.

#10 in reply to: ↑ 6 @peterwilsoncc
2 years ago

  • Keywords fixed-major added
  • Milestone changed from 6.1 to 6.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to audrasjb:

Worth noting it's also possible to backport this to the next minor, since the endpoint doesn't work anymore.

I've reopened the ticket and changed the milestone to do so.

There is precedent for this when the Rdio, CollegeHumor, Instagram and Facebook endpoints were deprecated.

I'm happy to hear from anyone who disagrees with backporting.

#11 @SergeyBiryukov
2 years ago

Backporting to 6.0.1 sounds good to me.

#12 @audrasjb
2 years ago

I'm in favor of backporting this changeset, too.

#13 @SergeyBiryukov
2 years ago

In 53646:

Docs: Update the version in which Meetup.com was removed as an oEmbed source.

Meetup.com was previously removed as an oEmbed source, since they have deprecated their endpoint. The block has also been removed from the editor, see #GB35085.

This commit updates the associated changelog entry for the oembed_providers filter to version 6.0.1, as the change is being backported to the 6.0 branch.

Follow-up to [53540].

See #55997.

#14 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 53647:

Embeds: Remove Meetup as an oEmbed source since the related endpoint has been deprecated.

This changeset removes Meetup as an oEmbed source, since Meetup.com have deprecated their oEmbed endpoint. The block has already been removed from the editor, see #GB35085.

Props peterwilsoncc, audrasjb, swissspidy, SergeyBiryukov.
Merges [53540] and [53646] to the 6.0 branch.
Fixes #55997.

Note: See TracTickets for help on using tickets.