WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#5600 closed task (blessed) (fixed)

ReadMe Version Bump To 2.5

Reported by: fitztrev Owned by: spencerp
Milestone: 2.5 Priority: lowest
Severity: normal Version: 2.5
Component: General Keywords: has-patch tested commit
Focuses: Cc:

Description

The current readme.html file has the WordPress version hardcoded in. I thought the purpose of wp-includes/version.php was so that we'd only have the version stored in one location.

Attachments (2)

readme.diff (387 bytes) - added by fitztrev 12 years ago.
readmehtml.diff (808 bytes) - added by spencerp 12 years ago.

Download all attachments as: .zip

Change History (11)

@fitztrev
12 years ago

#1 @spencerp
12 years ago

  • Owner changed from anonymous to spencerp

Just added an up-to-date version of the readme file from latest trunk revision.

#2 follow-up: @JeremyVisser
12 years ago

It's not possible to have this grabbed from wp-includes/version.php, because it's a static PHP file that cannot run PHP. This is because the file is designed to be viewed by WordPress users who download the zip/tarball, then look at the readme.html file by double-clicking it in their file browser. Users will likely not read this file as served by a web server -- rather, from a file:// URL, which means no PHP.

That's why it's hardcoded.

#3 @spencerp
12 years ago

  • Priority changed from normal to lowest

#4 @spencerp
12 years ago

  • Type changed from enhancement to task

#5 in reply to: ↑ 2 @fitztrev
12 years ago

That's why it's hardcoded.

I realize that it can't be changed to grab the version variable value from wp-includes/version.php, but I don't think that the version number is even necessary in the README, anyway. It creates an extra burden for the developers to bump the version here, too. Also, I don't think it's that important to have in their for the readers in the first place. My patch removes it altogether.

#6 @spencerp
12 years ago

  • Summary changed from ReadMe cleanup to ReadMe Version Bump To 2.5

#7 @thee17
12 years ago

  • Keywords has-patch tested-working added
  • Version set to 2.5

#8 @darkdragon
12 years ago

  • Keywords tested commit added; tested-working removed

@spencerp
12 years ago

#9 @ryan
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6608]) Bump ver in readme. Props fitzrev and spencerp. fixes #5600

Note: See TracTickets for help on using tickets.