#56011 closed enhancement (fixed)
Twenty Twenty: Add support for Plain style in Quote block
Reported by: | kajalgohel | Owned by: | karmatosed |
---|---|---|---|
Milestone: | 6.7 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | ui, css | Cc: |
Description
In Twenty Twenty Theme, when we add Quote block in editor side, the styles option named Plain is not reflected in front-side and editor-side. Actually the Default Styles and Plain Styles are looking same in both the side.
Steps to replicate:
1: Activate the Twenty Twenty Theme
2: Add Quote block
3: Choose Plain styles option
4: See block at editor side(block is looking same, nothing change)
5: Save Page/Post
6: View the page/post at front side
For better understanding I provide video attachment URL.
Video URL: https://share.cleanshot.com/iIXb2WcfmC4un0eapOgG
Thanks
Attachments (5)
Change History (14)
This ticket was mentioned in PR #2830 on WordPress/wordpress-develop by MatthiasReinholz.
2 years ago
#1
- Keywords has-patch added; needs-patch removed
#3
@
8 weeks ago
- Keywords needs-testing added
Thank you everyone. I think we can work towards getting this in as I also don't see a change in the two block styles.
- I am curious first to check where we are getting the plain style from so we can be sure to check it.
- Then I want to be sure which patch is the correct one - the one with or without the border.
- After that let's get some testing.
@
7 weeks ago
removes the border and sets the same value for both left and right padding (2rem, or 20px)
#5
@
7 weeks ago
- Summary changed from Twenty Twenty: styles issue in Quote block to Twenty Twenty: Add support for Plain style in Quote block
- Type changed from defect (bug) to enhancement
- Version changed from 6.0 to 5.9
GB29856 added the Plain style, and block-library/theme.css
assigns border: none
(only if the theme opts in to wp-block-styles
). The style's original design involved padding without the border.
To remove the border, I prefer border-width: 0
instead of border: none
, just in case the block might have special border controls in the future. Both 56011.border.diff and 56011.border-padding.diff use border-width
.
Padding:
- 56011.border.diff keeps the current padding to avoid making a decision for other people.
- With the lack of a difference between Default and Plain, I expect that few sites would have chosen the Plain option already. Changing the padding now likely would have little impact on existing sites' Quote blocks.
- If the padding is edited, both the left and right padding probably should match. Then the CSS would use shorthand values instead of all four sides. In 56011.border-padding.diff, I chose to match the current left padding on the right side and to keep the same top and bottom values (
0.5rem 2rem
on the front, and the pixel equivalent5px 20px
in the editor).
#6
@
7 weeks ago
- Owner set to karmatosed
- Status changed from new to assigned
Thank you @sabernhardt I am going to assign to myself and go through testing this now.
Adding missing styles for block style
plain
.Trac ticket: https://core.trac.wordpress.org/ticket/56011