#56019 closed defect (bug) (fixed)
Add prepare_links method to WP_REST_Post_Types_Controller
Reported by: | spacedmonkey | Owned by: | spacedmonkey |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | REST API | Keywords: | good-first-bug has-patch commit add-to-field-guide |
Focuses: | rest-api | Cc: |
Description (last modified by )
Move link logic to prepare_links
method in WP_REST_Post_Types_Controller
to bring this controller inline with other controllers.
Change History (14)
This ticket was mentioned in PR #2883 on WordPress/wordpress-develop by dlh01.
2 years ago
#2
- Keywords has-patch added; needs-patch removed
spacedmonkey commented on PR #2883:
2 years ago
#3
@dlh01 Let's keep these as they own tickets.
Can you add some unit tests as well please.
spacedmonkey commented on PR #2883:
2 years ago
#5
@spacedmonkey Are you saying you want separate PRs for each ticket?
Yes please.
This ticket was mentioned in PR #2965 on WordPress/wordpress-develop by dlh01.
2 years ago
#6
Split from #2883.
Trac ticket: https://core.trac.wordpress.org/ticket/56019
2 years ago
#7
@spacedmonkey I've opened #2965 and #2966 for the separate tickets and will close this PR.
I see that post type and taxonomy links are currently being tested in `WP_Test_REST_Post_Types_Controller::check_post_type_obj()` and `WP_Test_REST_Taxonomies_Controller::check_taxonomy_object()`, respectively. Could you elaborate on what kind of test coverage you'd like added?
#8
@
2 years ago
- Milestone changed from Future Release to 6.1
- Owner set to spacedmonkey
- Status changed from new to assigned
spacedmonkey commented on PR #2965:
2 years ago
#11
Committed
Trac ticket: https://core.trac.wordpress.org/ticket/56019
Trac ticket: https://core.trac.wordpress.org/ticket/56020