Make WordPress Core

Opened 21 months ago

Closed 20 months ago

Last modified 20 months ago

#56027 closed defect (bug) (fixed)

Placement of semi colon and error & strong tags is inconsistent.

Reported by: nekojonez's profile NekoJonez Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.1 Priority: normal
Severity: normal Version: 6.0
Component: Text Changes Keywords: has-patch
Focuses: ui Cc:

Description (last modified by SergeyBiryukov)

In the ticket, #50785 one error message was changed slightly but now it's not changed for all errors.

If you go and check, you notice that it's a mix between the ":" before or after the closing strong tag.

I wouldn't mind making the patch and PR for this... But I would love to hear if we want the ":" in errors with strong tags before or after the closing strong tag.

Change History (10)

This ticket was mentioned in Slack in #polyglots by nekojonez. View the logs.


21 months ago

#2 @NekoJonez
21 months ago

I just noticed that trac here cut off with "strong", so you'll have to copy the whole url.

#3 follow-up: @Presskopp
21 months ago

same goes with .</strong> and </strong>.

..also we use <strong>You have successfully updated WordPress!</strong>

Last edited 21 months ago by Presskopp (previous) (diff)

#4 @SergeyBiryukov
21 months ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 6.1

#5 in reply to: ↑ 3 @NekoJonez
21 months ago

Replying to Presskopp:

same goes with .</strong> and </strong>.

..also we use <strong>You have successfully updated WordPress!</strong>

I'll go through them.

#6 @NekoJonez
21 months ago

So, @Presskopp do I make a new ticket for that or do I add them in my PR for this one. I think I'll start working on this really soon :)

Edit: I checked them as well and I wouldn't change any of them apart from one. I included that in my PR.

Last edited 21 months ago by NekoJonez (previous) (diff)

This ticket was mentioned in PR #2835 on WordPress/wordpress-develop by NekoJonez.


21 months ago
#7

  • Keywords has-patch added

In ticket https://core.trac.wordpress.org/ticket/56027, I talked about how two errors were forgotten to place the ":" before the closing strong tag.
Also, Presskop suggested taking a look at other punctuation marks. Thankfully, most of them are fine for that. Except for one, where the "." isn't the focus of the bold segment, so I moved it.

This ticket was mentioned in Slack in #core by nekojonez. View the logs.


20 months ago

#9 @SergeyBiryukov
20 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 53700:

Text Changes: Improve consistency of punctuation in some strings.

  • Move the colon inside the <strong> tags in some Error: prefixes, to match other strings.
  • Move the full stop at the end of some sentences outside of the <strong> tags used for individual phrases.

Follow-up to [11669], [23844], [53118], [53458], [53476].

Props NekoJonez, Presskopp.
Fixes #56027.

SergeyBiryukov commented on PR #2835:


20 months ago
#10

Thanks for the PR! Merged in r53700.

Note: See TracTickets for help on using tickets.