#56027 closed defect (bug) (fixed)
Placement of semi colon and error & strong tags is inconsistent.
Reported by: | NekoJonez | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | 6.0 |
Component: | Text Changes | Keywords: | has-patch |
Focuses: | ui | Cc: |
Description (last modified by )
In the ticket, #50785 one error message was changed slightly but now it's not changed for all errors.
If you go and check, you notice that it's a mix between the ":" before or after the closing strong tag.
I wouldn't mind making the patch and PR for this... But I would love to hear if we want the ":" in errors with strong tags before or after the closing strong tag.
Change History (10)
This ticket was mentioned in Slack in #polyglots by nekojonez. View the logs.
2 years ago
#3
follow-up:
↓ 5
@
2 years ago
same goes with .</strong>
and </strong>.
#5
in reply to:
↑ 3
@
2 years ago
Replying to Presskopp:
same goes with
.</strong>
and</strong>.
..also we use
<strong>You have successfully updated WordPress!</strong>
I'll go through them.
#6
@
2 years ago
So, @Presskopp do I make a new ticket for that or do I add them in my PR for this one. I think I'll start working on this really soon :)
Edit: I checked them as well and I wouldn't change any of them apart from one. I included that in my PR.
This ticket was mentioned in PR #2835 on WordPress/wordpress-develop by NekoJonez.
2 years ago
#7
- Keywords has-patch added
In ticket https://core.trac.wordpress.org/ticket/56027, I talked about how two errors were forgotten to place the ":" before the closing strong tag.
Also, Presskop suggested taking a look at other punctuation marks. Thankfully, most of them are fine for that. Except for one, where the "." isn't the focus of the bold segment, so I moved it.
This ticket was mentioned in Slack in #core by nekojonez. View the logs.
2 years ago
#9
@
2 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 53700:
SergeyBiryukov commented on PR #2835:
2 years ago
#10
Thanks for the PR! Merged in r53700.
I just noticed that trac here cut off with "strong", so you'll have to copy the whole url.