Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#56042 closed defect (bug) (reported-upstream)

force enable SNI in socks request if SNI supported

Reported by: puvipavan's profile puvipavan Owned by:
Milestone: Priority: normal
Severity: major Version: 6.1
Component: HTTP API Keywords: has-patch
Focuses: administration Cc:


Hello there,

It's 2022 and most of the servers are dropping support for the non sni supported clients.

Following line disables SNI if the verify peer is disabled. It leads to connection error if the server does not support non SNI clients.

Please fix it.


Change History (6)

This ticket was mentioned in PR #2855 on WordPress/wordpress-develop by Puvipavan.

2 years ago

Trac ticket: 56042

#2 @puvipavan
2 years ago

Please let me know if I need to do anything for this PR:

#3 @hellofromTonya
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

Hello @puvipavan,

Welcome to WordPress Trac! Thank you for opening the ticket.

The change requested is part of the Requests, which is a separate library maintained here WordPress Core consumes that library but work on it is within its repo.

I'd suggest opening an issue here and then potentially opening a PR here

I'll go ahead and close this ticket as reported upstream. If you could please (really appreciate you), add a comment to this ticket with the link to the issue you open in Requests. Why? That way the 2 tickets are wired together and anyone reading this ticket will be redirected to follow progress in the Requests repo.

#4 @puvipavan
2 years ago

Hi @hellofromTonya

No problem. Thanks for your suggestion. Here is the issue link:

#5 @hellofromTonya
2 years ago

Thank you @puvipavan! I appreciate your efforts and time. Welcome again to WordPress Core. Cheers :)

desrosj commented on PR #2855:

2 years ago

Closing this out as it's superseded by WordPress/Requests/issues/757.

Note: See TracTickets for help on using tickets.