force enable SNI in socks request if SNI supported

[puvipavan]

Hello there,

It's 2022 and most of the servers are dropping support for the non sni supported clients.

Following line disables SNI if the verify peer is disabled. It leads to connection error if the server does not support non SNI clients.

Please fix it.

Thanks!

Trac ticket: 56042

[puvipavan]

Please let me know if I need to do anything for this PR: ​https://github.com/WordPress/wordpress-develop/pull/2855

[hellofromTonya]

Hello @puvipavan,

Welcome to WordPress Trac! Thank you for opening the ticket.

The change requested is part of the Requests, which is a separate library maintained here ​https://github.com/wordpress/requests. WordPress Core consumes that library but work on it is within its repo.

I'd suggest opening an issue here ​https://github.com/WordPress/Requests/issues and then potentially opening a PR here ​https://github.com/WordPress/Requests/pulls.

I'll go ahead and close this ticket as reported upstream. If you could please (really appreciate you), add a comment to this ticket with the link to the issue you open in Requests. Why? That way the 2 tickets are wired together and anyone reading this ticket will be redirected to follow progress in the Requests repo.

[puvipavan]

Hi @hellofromTonya

No problem. Thanks for your suggestion. Here is the issue link: ​https://github.com/WordPress/Requests/issues/757

[hellofromTonya]

Thank you @puvipavan! I appreciate your efforts and time. Welcome again to WordPress Core. Cheers :)

Closing this out as it's superseded by WordPress/Requests/issues/757.