Add filters to allow the shortcut return to wp_load_alloptions

[pbearne]

This adds a shortcut filter to the wp_load_options function

[joyously]

The Code Reference for get_option says

When one of the Options API filters is used: pre_option_$option, default_option_$option, or option_$option, the returned value may not match the expected type.

So, there are already filters. Exactly which functions need which filters?

Trac ticket: https://core.trac.wordpress.org/ticket/56045

[SergeyBiryukov]

Hi there, thanks for the ticket and the PR!

This looks like a duplicate of #37930.

[pbearne]

Replying to joyously:

The Code Reference for get_option says

When one of the Options API filters is used: pre_option_$option, default_option_$option, or option_$option, the returned value may not match the expected type.

So, there are already filters. Exactly which functions need which filters?

I have removed the filter for get_options as there is already a patch https://core.trac.wordpress.org/ticket/37930

[pbearne]

@SergeyBiryukov this is not a dupe as it is a shortcut filter for WP_load_alloptions

[SergeyBiryukov]

Replying to pbearne:

this is not a dupe as it is a shortcut filter for WP_load_alloptions

Thanks for the clarification! Yeah, let's keep this one for the pre_wp_load_alloptions filter then.

[mukesh27]

Hi there!

Thanks for the ticket and PR. It looks good, except for the small problem with the doc block for the filter.

Moving to the 6.1 milestone for consideration.

[pbearne]

@mukesh27 fixed doc block
Thanks for the review

[spacedmonkey]

@davidbaumwald Are you good to commit?

[davidbaumwald]

@spacedmonkey Yep. I'll work this in after 6.1 Beta 1.

[davidbaumwald]

@pbearne @spacedmonkey I apologize for not catching this sooner, but this is actually an Enhancement not a Bug. As such, this can't be committed to 6.1 since the deadline for FEA/ENH was Beta 1 a couple of days ago.

Updating the ticket to properly type it and punting to 6.2 to make sure it gets in.

[costdev]

I've requested some changes on the PR :) Updating the ticket's keywords to swap needs-refresh for changes-requested.

Trac ticket: https://core.trac.wordpress.org/ticket/56045

[costdev]

I have updated the patch to address the remaining feedback. See ​PR 4016.

Adding for commit consideration.

Additional props: @mukesh27

[spacedmonkey]

In 55256:

Options, Meta APIs: Add a filter to allow the shortcut return to wp_load_alloptions function.

Add a new filter pre_wp_load_alloptions in the wp_load_alloptions function to short circuit the return value.

Props pbearne, spacedmonkey, joyously, SergeyBiryukov, mukesh27, costdev.
Fixes #56045.

Committed

code review changes made

[milana_cap]

@pbearne @spacedmonkey, do we have a volunteer to write the Dev note?

[flixos90]

Drafted a note for this to be included in the Field Guide's notes section, as shared in ​https://wordpress.slack.com/archives/C02KGN5K076/p1677531978930639?thread_ts=1677512400.171959&cid=C02KGN5K076.

[spacedmonkey]

#54622 was marked as a duplicate.