Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #56051, comment 10


Ignore:
Timestamp:
08/04/2022 07:35:12 PM (3 years ago)
Author:
itmapl
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #56051, comment 10

    initial v1  
    11> If I understand this correctly, the goal is to have to load and process the language files >once, so a persistent cache makes sense. I'm not sure how large the data is and if maybe using >the core Transient API would be better here? Ideally using an existing caching API is >preferable over writing files directly which might not work as expected.
    22
    3 Definitely correct, and yes Transient API fits much better in that case. Here https://github.com/itma/WordPress/commits/l10n-caching-transient-api/wp-includes/l10n.php I've been working on the ticket, and made a first step porting the code into Transient API.
     3Definitely correct, and yes Transient API fits much better in that case. Here https://github.com/itma/WordPress/commits/l10n-caching-transient-api/wp-includes/l10n.php I've been working on the ticket, and made the first step porting the code into Transient API.
    44
    55> Caches would also need to get updated on core, plugin and theme updates where strings could >potentially change. If core doesn't already have a "languages_updated" action maybe consider >adding one.