WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#56072 closed defect (bug) (fixed)

REST API: menu items 'type_label' schema defined twice

Reported by: dlh's profile dlh Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version: 5.9
Component: REST API Keywords: has-patch commit
Focuses: Cc:

Description

The schema for the type_label property is defined twice in WP_REST_Menu_Items_Controller::get_item_schema(). The linked Pull Request removes the second definition (but keeps its more-descriptive description).

Change History (5)

#2 @SergeyBiryukov
3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.1

#3 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

Hi,
The PR looks good to me. Self-assnigning for commit.

#4 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53678:

REST API: Consolidate menu item type_label schema declaration.

This changeset removes a duplicate definition of the type_label property and consolidates the description of this property.

Props dlh, SergeyBiryukov.
Fixes #56072.

Note: See TracTickets for help on using tickets.