Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#56093 closed defect (bug) (fixed)

Register Comments Query Loop from metadata to enable title and description translation.

Reported by: cbravobernal Owned by: SergeyBiryukov
Priority: normal Milestone: 6.0.1
Component: Editor Version: 6.1
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

[As mentioned on Github](https://github.com/WordPress/wordpress-develop/pull/2826#issuecomment-1168570558). We need to create a patch to add to trunk the Comments Query Loop registration from metadata.

That way it will fix the current use while Comments Query Loop title and description is not being translated on 6.0

It will also need a manual patch on the branch 6.0 to fix it in the future 6.0.1 release.

Fixes #55809

Change History (8)

This ticket was mentioned in PR #2921 on WordPress/wordpress-develop by c4rl0sbr4v0.


4 years ago
#1

  • Keywords has-patch added

Add registration from metadata to Comments Query Loop in order to enable translations for the title and description.

Trac ticket: https://core.trac.wordpress.org/ticket/56093

ockham commented on PR #2921:


4 years ago
#2

@gziolo @adamziel Can we have this once included in WP 6.0.1? 🙌

adamziel commented on PR #2921:


4 years ago
#3

Sure! CC @SergeyBiryukov

gziolo commented on PR #2921:


4 years ago
#4

Excellent but simple fix ❤️

#5 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review6.0.1

#6 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status newclosed

In 53631:

Editor: Register the Comments Query Loop block from metadata.

This ensures that the block title and description can be translated.

Follow-up to [53157].

Props cbravobernal, bernhard-reiter, adamziel, gziolo, peterwilsoncc, audrasjb, mukesh27, SergeyBiryukov.
Fixes #56093. See #55809.

#7 @SergeyBiryukov
4 years ago

In 53632:

Editor: Register the Comments Query Loop block from metadata.

This ensures that the block title and description can be translated.

Follow-up to [53157].

Props cbravobernal, bernhard-reiter, adamziel, gziolo, peterwilsoncc, audrasjb, mukesh27, SergeyBiryukov.
Merges [53631] to the 6.0 branch.
Fixes #56093. See #55809.

SergeyBiryukov commented on PR #2921:


4 years ago
#8

Thanks for the PR! Merged in r53631, backported to the 6.0 branch in r53632.

Note: See TracTickets for help on using tickets.