#56095 closed task (blessed) (fixed)
Remove unnecessary Slack workflow runs for old branches
Reported by: | desrosj | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Description
In [51934], Slack notifications for GitHub Action workflows were restored for older branches. This was done by adding the workflow_run
event to the Slack workflow in trunk
, which restored notifications without having to backport anything.
While this works, one downfall of this method is a separate workflow run is created to send notifications for every qualifying workflow that completes. This means there are 2 workflows for every one that runs instead of 1.
It also makes it difficult to track which Slack workflow belongs to a normal workflow run.
The Slack workflow is a reusable one and when used this way, the notifications are done as a part of the original workflow. The 5.9 branch and newer have used it in this way instead on the workflow_run
event, and it has worked well.
Let's backport this to the older branches to help limit the noise caused by excessive workflow runs and to simplify the Slack notifications workflow by eliminating any logic specific to the workflow_run
event (which has data passed in different ways).
The original work for making the Slack notification workflow a reusable one was done as part of #53363, and initially introduced in [51921].
Change History (83)
This ticket was mentioned in PR #2918 on WordPress/wordpress-develop by desrosj.
2 years ago
#1
This ticket was mentioned in PR #2592 on WordPress/wordpress-develop by desrosj.
2 years ago
#2
Core changesets:
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2895 on WordPress/wordpress-develop by desrosj.
2 years ago
#3
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2896 on WordPress/wordpress-develop by desrosj.
2 years ago
#4
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2897 on WordPress/wordpress-develop by desrosj.
2 years ago
#5
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2898 on WordPress/wordpress-develop by desrosj.
2 years ago
#6
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2899 on WordPress/wordpress-develop by desrosj.
2 years ago
#7
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2900 on WordPress/wordpress-develop by desrosj.
2 years ago
#8
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2901 on WordPress/wordpress-develop by desrosj.
2 years ago
#9
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2902 on WordPress/wordpress-develop by desrosj.
2 years ago
#10
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2903 on WordPress/wordpress-develop by desrosj.
2 years ago
#11
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2904 on WordPress/wordpress-develop by desrosj.
2 years ago
#12
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2905 on WordPress/wordpress-develop by desrosj.
2 years ago
#13
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2908 on WordPress/wordpress-develop by desrosj.
2 years ago
#14
Core changesets:
50446
50473
50704
50796
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2909 on WordPress/wordpress-develop by desrosj.
2 years ago
#15
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2910 on WordPress/wordpress-develop by desrosj.
2 years ago
#16
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2911 on WordPress/wordpress-develop by desrosj.
2 years ago
#17
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2912 on WordPress/wordpress-develop by desrosj.
2 years ago
#18
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2913 on WordPress/wordpress-develop by desrosj.
2 years ago
#19
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2914 on WordPress/wordpress-develop by desrosj.
2 years ago
#20
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2915 on WordPress/wordpress-develop by desrosj.
2 years ago
#21
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2916 on WordPress/wordpress-develop by desrosj.
2 years ago
#22
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2917 on WordPress/wordpress-develop by desrosj.
2 years ago
#23
Core changesets:
50446
50473
50704
50930
51341
51355
51498
51511
51535
51921
51924
51925
51937
52002
52130
52183
52233
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2923 on WordPress/wordpress-develop by desrosj.
2 years ago
#24
Core changesets:
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
This ticket was mentioned in PR #2924 on WordPress/wordpress-develop by desrosj.
2 years ago
#25
Core changesets:
53112
53581
53582
Trac ticket: https://core.trac.wordpress.org/ticket/56095
#26
@
2 years ago
Another thing to mention about using the Slack workflow as a reusable one is that the workflow is called from a specific branch, tag, or SHA. So future modifications to how the workflow works can be made once to trunk
and will automatically apply to all older branches.
2 years ago
#81
Merged into Core in https://core.trac.wordpress.org/changeset/53591.
This removes the
workflow_run
event and any related logic from the Slack workflow. The changes required to use the workflow as a callable one in older branches are staged and ready to go. This will avoid having to create a separate workflow run to send Slack notifications for older branches.Trac ticket: https://core.trac.wordpress.org/ticket/56095