Context Navigation

Hi there, thanks for the patch! It looks good to me and seems to match the escaping of comment author's email in WP_Comments_List_Table::column_author().

This was not introduced in [15955] though, it dates back to [9098] / #7435 for WP 2.7, followed by [11109] and [11204].

#4 @audrasjb
4 years ago

Owner set to audrasjb
Status new → accepted

Self assigning for commit, as it looks good to go.

#5 @audrasjb
4 years ago

Resolution → fixed
Status accepted → closed

In 53640:

Comments: Use more appropriate escaping functions in class WP_Comments_List_Table.

This changeset replaces esc_attr escaping function with esc_html as it is more appropriate in this context.

Props chintan1896, afragen, peterwilsoncc, SergeyBiryukov.
Fixes #56101.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#56101 closed defect (bug) (fixed)

Need to use esc_html escaping function instead of esc_attr.

Description

Attachments (1)

Change History (6)

@chintan1896 4 years ago

#1 @afragen 4 years ago

#2 @peterwilsoncc 4 years ago

#3 @SergeyBiryukov 4 years ago

#4 @audrasjb 4 years ago

#5 @audrasjb 4 years ago

Download in other formats:

@chintan1896
4 years ago

#1 @afragen
4 years ago

#2 @peterwilsoncc
4 years ago

#3 @SergeyBiryukov
4 years ago

#4 @audrasjb
4 years ago

#5 @audrasjb
4 years ago