WordPress.org

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#5611 closed enhancement (fixed)

PHPdoc effort for phpdoc fixes in 2.5

Reported by: darkdragon Owned by:
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Optimization Keywords: phpdoc
Focuses: Cc:

Description

For any mistakes with the phpdoc, patches will be here for WordPress 2.5.

Attachments (1)

phpdocfixes.phpdoc.r6582.diff (9.6 KB) - added by darkdragon 14 years ago.
First round of phpdoc fixes based off of r6582

Download all attachments as: .zip

Change History (9)

@darkdragon
14 years ago

First round of phpdoc fixes based off of r6582

#1 @darkdragon
14 years ago

Patch also includes file level documentation for rss.php.

#2 @darkdragon
14 years ago

When patch is committed, it should be the last external library file that needs file level documentation.

Patch also "fixes" @since information that has 2.4 as the version and moves it to 2.5. The reason for this even though it was added during the 2.4 development was that the since information is for actual releases and the 2.4 was a guess as to which (trunk) version that would be. The current trunk version is 2.5, so all 2.4 @since tags should be 2.5 instead.

#3 @ryan
14 years ago

(In [6585]) phpdoc tuneup from darkdragon. see #5611

#4 @sambauers
14 years ago

[6585] contains a change to code:

wp-settings.php - line @39

- unset( $wp_filter, $wp_action, $cache_lastcommentmodified, $cache_lastpostdate );
+ unset( $wp_filter, $cache_lastcommentmodified, $cache_lastpostdate );

Is that a problem?

#5 @darkdragon
14 years ago

No. Once upon a time {{{$wp_action} was added to split filters and actions. When actions once again became part of filters, the variable was left over from that.

$wp_actions is however being used.

#6 @darkdragon
14 years ago

Actually, I "fixed" that a few months ago and when I made the patch forgot that I had fixed it.

I try to keep surprises to a minimum since it could affect whether or not the patch is committed.

#7 @westi
14 years ago

  • Keywords has-patch commit removed

#8 @darkdragon
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Reopen if someone has more phpdoc fixes for 2.5. Create new ticket for 2.6.

Fixed in [6585].

Note: See TracTickets for help on using tickets.