Opened 2 years ago
Closed 23 months ago
#56114 closed defect (bug) (fixed)
Multiple Themes: Separator Block Dots Style Width
Reported by: | umesh84 | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | 5.8 |
Component: | Bundled Theme | Keywords: | has-screenshots has-patch commit |
Focuses: | ui, css | Cc: |
Description (last modified by )
Twenty Fifteen Themes Separator Block Dots styling issue in editor and Front
Steps to replicate:
1: Activate the Twenty Fifteen Themes
2: add Separator block
3: Select Dots style
URL: https://www.loom.com/share/a532739c54594c98ac3ddb49c56f6002
Attachments (20)
Change History (28)
#2
@
2 years ago
- Description modified (diff)
- Keywords needs-patch added; has-patch removed
- Summary changed from Themes Twenty Fifteen Separator Block Dots styling Issue to Multiple Themes: Separator Block Dots Style Width
- Version changed from 6.0 to 5.8
Thanks for the report! The theme should be corrected, even if a change to the editor would fix the problem.
Some themes set the Separator block max-width
to 100px without making an exception for the Dots style, which had worked with earlier versions of Gutenberg. Then GB30255 switched max-width: none
to width: none
, and GB33793 removed that for being invalid.
Twenty Fifteen already adjusts the max-width
for Wide separators:
.wp-block-separator.is-style-wide { max-width: 100%; }
And it could have the same for the Dots style:
.wp-block-separator.is-style-wide, .wp-block-separator.is-style-dots { max-width: 100%; }
Twenty Fifteen would need edits to both blocks.css and editor-blocks.css.
Other themes would need a similar change in only the blocks.css file (for the front end):
- Twenty Eleven
- Twenty Thirteen
- Twenty Fourteen
- Twenty Sixteen
#3
@
2 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 6.2
#4
@
2 years ago
Test Report
Patch resolve the issue.
I have tested this issue and tested the patch also. It's really works fine for using this code as mentioned by sabernhardt,
.wp-block-separator.is-style-wide, .wp-block-separator.is-style-dots { max-width: 100%; }
#5
@
23 months ago
Test Report
Patch tested: https://core.trac.wordpress.org/attachment/ticket/56114/56114.1.patch
Environment
OS: Windows 10 version 22H2
Web Server: Nginx
PHP: 7.4.30
WordPress: 6.2-alpha-54642-src
Browser: Chrome 109.0.5414.87
Theme: Twenty Twenty-fifteen
Active Plugins: No plugins activated.
Actual Results
✅ Expected result works as expected with the patch.
Supplemental Artifacts
Before Patch: https://d.pr/i/JLHtgf
After Patch: https://d.pr/i/0h5BXA
#6
@
23 months ago
- Owner set to audrasjb
- Status changed from new to reviewing
Self assigning for final testing/review and commit.
For better understanding I have attached a screenshot