Make WordPress Core

Opened 22 months ago

Closed 2 weeks ago

#56138 closed defect (bug) (worksforme)

Twenty Nineteen: Alignment issue in Button block

Reported by: kajalgohel's profile kajalgohel Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.0.3
Component: Bundled Theme Keywords: has-patch needs-testing close
Focuses: ui, css Cc:

Description

In Twenty Nineteen Theme, when we add Button block in editor side and change the alignment of Button then the "Align right" is not reflected in backend as well as frontend side.

Steps to replicate:
1: Activate the Twenty Nineteen Theme
2: Add Button block
3: Choose "Align right" from Align option
4: View the page/post at editor side
5: Save Page/Post
6: View the page/post at front side

For better understanding I provide video attachment link.

Video link: https://share.cleanshot.com/6IuBdTOGj2AwxsqaPA3C

Thanks

Attachments (2)

#56138.patch (929 bytes) - added by kmadhak 22 months ago.
Added Patch for Editor Side
56138.patch (937 bytes) - added by varshil151189 22 months ago.
Patch file for the Frontend side

Download all attachments as: .zip

Change History (10)

@kmadhak
22 months ago

Added Patch for Editor Side

@varshil151189
22 months ago

Patch file for the Frontend side

#1 @varshil151189
22 months ago

  • Keywords needs-testing added; needs-patch removed

#2 @kmadhak
22 months ago

  • Keywords has-patch added

#3 @ugyensupport
22 months ago

I could replicate this button block issue on alignment to the right side.
How could I reproduce
Steps to replicate:
1: Activate the T20 Theme
2: Add Button block
3: Choose "Align right" from Align option
4: View the page/post on the editor side
5: Save Page/Post
6: View the page/post on the front side

WordPress Version : 6.0
Operating System: MACOS 11.6.6
Browser : Google Chrome 10.5

Props to @kajalgohel Video link: https://share.cleanshot.com/6IuBdTOGj2AwxsqaPA3C

#4 @alvitazwar052
11 months ago

  • Keywords needs-testing has-patch removed
  • Version changed from 6.0 to 6.0.3

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56138/56138.patch

Environment

  • OS: macOS 12.4
  • Web Server: Nginx
  • PHP: 7.4.33
  • WordPress: 6.3-alpha-55505-src
  • Browser: Chrome
  • Theme: Twenty Twenty-two, Twenty-nineteen

ScreenCast

With Twenty-nineteen Theme: https://www.loom.com/share/3d8d34d261f64e57ab37ac30e3d33bbf
With Twenty-Twenty-two Theme: https://www.loom.com/share/dde01f2dc4d74a318caa8cb3abe1a65d

Actual Results

  • Right alignment issue is fixed with the patch✅
Last edited 11 months ago by alvitazwar052 (previous) (diff)

#5 @karmatosed
3 weeks ago

  • Keywords has-patch needs-testing added

#6 @sabernhardt
2 weeks ago

#56536 was marked as a duplicate.

#7 @sabernhardt
2 weeks ago

  • Keywords close added

The block toolbar does not have an "Align right" option anymore, so this could be considered fixed without changing the theme.

  • If you want to position the "Button" link to the right, use the "Justify items right" option.
  • If you want to align the text within the link, you can use the "Align text right" option.

#8 @sabernhardt
2 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Those legacy alignment options were removed in https://github.com/WordPress/gutenberg/pull/45663

I'll close this and the similar ticket #57257, but feel free to reopen if you experience the problem again.

Note: See TracTickets for help on using tickets.